Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 2777283004: Do not build Password Reuse on Android and iOS (Closed)
Patch Set: Changed #ifdef to OS defines Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/BUILD.gn
diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn
index 8b4356cda8a95e92cca4890d35e3092db09afd7b..df3e2ed827c388bcf2b45570d0d0b101fdbcd387 100644
--- a/components/password_manager/core/browser/BUILD.gn
+++ b/components/password_manager/core/browser/BUILD.gn
@@ -8,6 +8,9 @@ if (is_android) {
import("//build/config/android/config.gni")
}
+# TODO(crbug.com/706392): Fix password reuse detection for Android.
+password_reuse_detection_support = !is_android && !is_ios
+
static_library("browser") {
sources = [
"affiliated_match_helper.cc",
@@ -99,12 +102,6 @@ static_library("browser") {
"password_manager_settings_migration_experiment.h",
"password_manager_util.cc",
"password_manager_util.h",
- "password_reuse_detection_manager.cc",
- "password_reuse_detection_manager.h",
- "password_reuse_detector.cc",
- "password_reuse_detector.h",
- "password_reuse_detector_consumer.cc",
- "password_reuse_detector_consumer.h",
"password_store.cc",
"password_store.h",
"password_store_change.cc",
@@ -135,6 +132,17 @@ static_library("browser") {
"webdata/password_web_data_service_win.h",
]
+ if (password_reuse_detection_support) {
+ sources += [
+ "password_reuse_detection_manager.cc",
+ "password_reuse_detection_manager.h",
+ "password_reuse_detector.cc",
+ "password_reuse_detector.h",
+ "password_reuse_detector_consumer.cc",
+ "password_reuse_detector_consumer.h",
+ ]
+ }
+
public_deps = [
"//base",
"//components/sync",
@@ -296,8 +304,6 @@ source_set("unit_tests") {
"password_manager_settings_migration_experiment_unittest.cc",
"password_manager_unittest.cc",
"password_manager_util_unittest.cc",
- "password_reuse_detection_manager_unittest.cc",
- "password_reuse_detector_unittest.cc",
"password_store_default_unittest.cc",
"password_store_origin_unittest.h",
"password_store_unittest.cc",
@@ -313,6 +319,12 @@ source_set("unit_tests") {
if (is_ios) {
sources += [ "login_database_ios_unittest.cc" ]
}
+ if (password_reuse_detection_support) {
+ sources += [
+ "password_reuse_detection_manager_unittest.cc",
+ "password_reuse_detector_unittest.cc",
+ ]
+ }
deps = [
":test_support",
":unit_tests_bundle_data",

Powered by Google App Engine
This is Rietveld 408576698