Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2776623002: Compile more targets in foreground/js/ui in gyp v2 (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile more targets in foreground/js/ui in gyp v2 BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2776623002 Cr-Commit-Position: refs/heads/master@{#459366} Committed: https://chromium.googlesource.com/chromium/src/+/b3e59c4efa72120f82d4f67d7097fab634d6157f

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 2 chunks +14 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
oka
.
3 years, 9 months ago (2017-03-24 02:31:35 UTC) #2
oka
.
3 years, 9 months ago (2017-03-24 03:24:28 UTC) #7
oka
PTAL.
3 years, 9 months ago (2017-03-24 03:25:16 UTC) #9
fukino
lgtm
3 years, 9 months ago (2017-03-24 05:12:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776623002/40001
3 years, 9 months ago (2017-03-24 05:13:34 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 05:40:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b3e59c4efa72120f82d4f67d7097...

Powered by Google App Engine
This is Rietveld 408576698