Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp

Issue 2776623002: Compile more targets in foreground/js/ui in gyp v2 (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
diff --git a/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp b/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
index 7ac05f37f3c20b87264751d00143802c97c7cb2d..cd31f4e9a76da3a302306888f1b795278078bff0 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
+++ b/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
@@ -35,14 +35,20 @@
# 'target_name': 'drag_selector',
# 'includes': ['../../../../compile_js2.gypi'],
# },
-# {
-# 'target_name': 'empty_folder',
-# 'includes': ['../../../../compile_js2.gypi'],
-# },
-# {
-# 'target_name': 'error_dialog',
-# 'includes': ['../../../../compile_js2.gypi'],
-# },
+ {
+ 'target_name': 'empty_folder',
+ 'dependencies': [
+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:util',
+ ],
+ 'includes': ['../../../../compile_js2.gypi'],
+ },
+ {
+ 'target_name': 'error_dialog',
+ 'dependencies': [
+ '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:dialogs',
+ ],
+ 'includes': ['../../../../compile_js2.gypi'],
+ },
# {
# 'target_name': 'file_grid',
# 'includes': ['../../../../compile_js2.gypi'],
@@ -87,8 +93,6 @@
{
'target_name': 'files_confirm_dialog',
'dependencies': [
- '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
- '<(DEPTH)/ui/webui/resources/js/cr/compiled_resources2.gyp:ui',
'<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:dialogs',
],
'includes': ['../../../../compile_js2.gypi'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698