Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2775743002: Compile more targets in foreground/js/ui in gyp v2 (2) (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile more targets in foreground/js/ui in gyp v2 (2) BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2775743002 Cr-Commit-Position: refs/heads/master@{#459371} Committed: https://chromium.googlesource.com/chromium/src/+/026cead1b2ff13a78bc044c62efd63b8efb0041e

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 2 chunks +22 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
oka
PTAL.
3 years, 9 months ago (2017-03-24 03:44:37 UTC) #3
fukino
3 years, 9 months ago (2017-03-24 05:13:31 UTC) #4
oka
I see no comments.
3 years, 9 months ago (2017-03-24 05:17:04 UTC) #5
fukino
lgtm
3 years, 9 months ago (2017-03-24 05:55:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775743002/20001
3 years, 9 months ago (2017-03-24 05:57:09 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 06:26:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/026cead1b2ff13a78bc044c62efd...

Powered by Google App Engine
This is Rietveld 408576698