Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2766313004: Compile targets in foreground/js/ui unconditionally (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile targets in foreground/js/ui unconditionally BUG=636289 Test=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2766313004 Cr-Commit-Position: refs/heads/master@{#459346} Committed: https://chromium.googlesource.com/chromium/src/+/9eb8ddc9e622f838f41b38abad84e4a0dc146bdf

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/file_manager/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
oka
PTAL.
3 years, 9 months ago (2017-03-24 00:59:13 UTC) #3
fukino
lgtm
3 years, 9 months ago (2017-03-24 01:01:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766313004/1
3 years, 9 months ago (2017-03-24 01:08:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/7202)
3 years, 9 months ago (2017-03-24 01:25:38 UTC) #9
oka
.
3 years, 9 months ago (2017-03-24 02:28:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766313004/20001
3 years, 9 months ago (2017-03-24 02:30:05 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 03:00:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9eb8ddc9e622f838f41b38abad84...

Powered by Google App Engine
This is Rietveld 408576698