Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2776253002: Move some database tests next to the files they cover. (Closed)

Created:
3 years, 9 months ago by pwnall
Modified:
3 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some database tests next to the files they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2776253002 Cr-Commit-Position: refs/heads/master@{#459941} Committed: https://chromium.googlesource.com/chromium/src/+/b68a2eea2e917f080110f6ae5d87c1e319832671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -528 lines) Patch
D content/browser/database_quota_client_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D content/browser/database_util_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/databases_table_unittest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M storage/browser/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A + storage/browser/database/database_quota_client_unittest.cc View 8 chunks +6 lines, -13 lines 0 comments Download
A + storage/browser/database/database_util_unittest.cc View 4 chunks +7 lines, -10 lines 0 comments Download
A + storage/browser/database/databases_table_unittest.cc View 4 chunks +7 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
pwnall
This is the last easy move CL. I'll start preparing the more difficult ones after ...
3 years, 9 months ago (2017-03-27 20:32:41 UTC) #4
kinuko
lgtm
3 years, 9 months ago (2017-03-27 22:24:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776253002/1
3 years, 9 months ago (2017-03-27 23:41:17 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 23:49:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b68a2eea2e917f080110f6ae5d87...

Powered by Google App Engine
This is Rietveld 408576698