Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: storage/browser/database/databases_table_unittest.cc

Issue 2776253002: Move some database tests next to the files they cover. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « storage/browser/database/database_util_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "sql/connection.h" 10 #include "sql/connection.h"
(...skipping 11 matching lines...) Expand all
22 22
23 static void CheckDetailsAreEqual(const DatabaseDetails& d1, 23 static void CheckDetailsAreEqual(const DatabaseDetails& d1,
24 const DatabaseDetails& d2) { 24 const DatabaseDetails& d2) {
25 EXPECT_EQ(d1.origin_identifier, d2.origin_identifier); 25 EXPECT_EQ(d1.origin_identifier, d2.origin_identifier);
26 EXPECT_EQ(d1.database_name, d2.database_name); 26 EXPECT_EQ(d1.database_name, d2.database_name);
27 EXPECT_EQ(d1.description, d2.description); 27 EXPECT_EQ(d1.description, d2.description);
28 EXPECT_EQ(d1.estimated_size, d2.estimated_size); 28 EXPECT_EQ(d1.estimated_size, d2.estimated_size);
29 } 29 }
30 30
31 static bool DatabasesTableIsEmpty(sql::Connection* db) { 31 static bool DatabasesTableIsEmpty(sql::Connection* db) {
32 sql::Statement statement(db->GetCachedStatement( 32 sql::Statement statement(
33 SQL_FROM_HERE, "SELECT COUNT(*) FROM Databases")); 33 db->GetCachedStatement(SQL_FROM_HERE, "SELECT COUNT(*) FROM Databases"));
34 return (statement.is_valid() && statement.Step() && !statement.ColumnInt(0)); 34 return (statement.is_valid() && statement.Step() && !statement.ColumnInt(0));
35 } 35 }
36 36
37 TEST(DatabasesTableTest, TestIt) { 37 TEST(DatabasesTableTest, TestIt) {
38 // Initialize the 'Databases' table. 38 // Initialize the 'Databases' table.
39 sql::Connection db; 39 sql::Connection db;
40 40
41 sql::test::ScopedErrorExpecter expecter; 41 sql::test::ScopedErrorExpecter expecter;
42 // TODO(shess): Suppressing SQLITE_CONSTRAINT because the code 42 // TODO(shess): Suppressing SQLITE_CONSTRAINT because the code
43 // expects that and handles the resulting error. Consider revising 43 // expects that and handles the resulting error. Consider revising
(...skipping 14 matching lines...) Expand all
58 DatabaseDetails details_in1; 58 DatabaseDetails details_in1;
59 DatabaseDetails details_out1; 59 DatabaseDetails details_out1;
60 details_in1.origin_identifier = "origin1"; 60 details_in1.origin_identifier = "origin1";
61 details_in1.database_name = ASCIIToUTF16("db1"); 61 details_in1.database_name = ASCIIToUTF16("db1");
62 details_in1.description = ASCIIToUTF16("description_db1"); 62 details_in1.description = ASCIIToUTF16("description_db1");
63 details_in1.estimated_size = 100; 63 details_in1.estimated_size = 100;
64 64
65 // Updating details for this database should fail. 65 // Updating details for this database should fail.
66 EXPECT_FALSE(databases_table.UpdateDatabaseDetails(details_in1)); 66 EXPECT_FALSE(databases_table.UpdateDatabaseDetails(details_in1));
67 EXPECT_FALSE(databases_table.GetDatabaseDetails( 67 EXPECT_FALSE(databases_table.GetDatabaseDetails(
68 details_in1.origin_identifier, 68 details_in1.origin_identifier, details_in1.database_name, &details_out1));
69 details_in1.database_name,
70 &details_out1));
71 69
72 // Inserting details for this database should pass. 70 // Inserting details for this database should pass.
73 EXPECT_TRUE(databases_table.InsertDatabaseDetails(details_in1)); 71 EXPECT_TRUE(databases_table.InsertDatabaseDetails(details_in1));
74 EXPECT_TRUE(databases_table.GetDatabaseDetails( 72 EXPECT_TRUE(databases_table.GetDatabaseDetails(
75 details_in1.origin_identifier, 73 details_in1.origin_identifier, details_in1.database_name, &details_out1));
76 details_in1.database_name,
77 &details_out1));
78 EXPECT_EQ(1, databases_table.GetDatabaseID(details_in1.origin_identifier, 74 EXPECT_EQ(1, databases_table.GetDatabaseID(details_in1.origin_identifier,
79 details_in1.database_name)); 75 details_in1.database_name));
80 76
81 // Check that the details were correctly written to the database. 77 // Check that the details were correctly written to the database.
82 CheckDetailsAreEqual(details_in1, details_out1); 78 CheckDetailsAreEqual(details_in1, details_out1);
83 79
84 // Check that inserting a duplicate row fails. 80 // Check that inserting a duplicate row fails.
85 EXPECT_FALSE(databases_table.InsertDatabaseDetails(details_in1)); 81 EXPECT_FALSE(databases_table.InsertDatabaseDetails(details_in1));
86 82
87 // Insert details for another database with the same origin. 83 // Insert details for another database with the same origin.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 116
121 // Get the list of all origins: should be "origin1" and "origin2". 117 // Get the list of all origins: should be "origin1" and "origin2".
122 std::vector<std::string> origins_out; 118 std::vector<std::string> origins_out;
123 EXPECT_TRUE(databases_table.GetAllOriginIdentifiers(&origins_out)); 119 EXPECT_TRUE(databases_table.GetAllOriginIdentifiers(&origins_out));
124 EXPECT_EQ(size_t(2), origins_out.size()); 120 EXPECT_EQ(size_t(2), origins_out.size());
125 EXPECT_EQ(details_in1.origin_identifier, origins_out[0]); 121 EXPECT_EQ(details_in1.origin_identifier, origins_out[0]);
126 EXPECT_EQ(details_in3.origin_identifier, origins_out[1]); 122 EXPECT_EQ(details_in3.origin_identifier, origins_out[1]);
127 123
128 // Delete an origin and check that it's no longer in the table. 124 // Delete an origin and check that it's no longer in the table.
129 origins_out.clear(); 125 origins_out.clear();
130 EXPECT_TRUE(databases_table.DeleteOriginIdentifier( 126 EXPECT_TRUE(
131 details_in3.origin_identifier)); 127 databases_table.DeleteOriginIdentifier(details_in3.origin_identifier));
132 EXPECT_TRUE(databases_table.GetAllOriginIdentifiers(&origins_out)); 128 EXPECT_TRUE(databases_table.GetAllOriginIdentifiers(&origins_out));
133 EXPECT_EQ(size_t(1), origins_out.size()); 129 EXPECT_EQ(size_t(1), origins_out.size());
134 EXPECT_EQ(details_in1.origin_identifier, origins_out[0]); 130 EXPECT_EQ(details_in1.origin_identifier, origins_out[0]);
135 131
136 // Deleting an origin that doesn't have any record in this table should fail. 132 // Deleting an origin that doesn't have any record in this table should fail.
137 EXPECT_FALSE(databases_table.DeleteOriginIdentifier("unknown_origin")); 133 EXPECT_FALSE(databases_table.DeleteOriginIdentifier("unknown_origin"));
138 134
139 // Delete the details for 'db1' and check that they're no longer there. 135 // Delete the details for 'db1' and check that they're no longer there.
140 EXPECT_TRUE(databases_table.DeleteDatabaseDetails( 136 EXPECT_TRUE(databases_table.DeleteDatabaseDetails(
141 details_in1.origin_identifier, details_in1.database_name)); 137 details_in1.origin_identifier, details_in1.database_name));
142 EXPECT_FALSE(databases_table.GetDatabaseDetails( 138 EXPECT_FALSE(databases_table.GetDatabaseDetails(
143 details_in1.origin_identifier, 139 details_in1.origin_identifier, details_in1.database_name, &details_out1));
144 details_in1.database_name,
145 &details_out1));
146 140
147 // Check that trying to delete a record that doesn't exist fails. 141 // Check that trying to delete a record that doesn't exist fails.
148 EXPECT_FALSE(databases_table.DeleteDatabaseDetails( 142 EXPECT_FALSE(databases_table.DeleteDatabaseDetails(
149 "unknown_origin", ASCIIToUTF16("unknown_database"))); 143 "unknown_origin", ASCIIToUTF16("unknown_database")));
150 144
151 ASSERT_TRUE(expecter.SawExpectedErrors()); 145 ASSERT_TRUE(expecter.SawExpectedErrors());
152 } 146 }
153 147
154 } // namespace content 148 } // namespace content
OLDNEW
« no previous file with comments | « storage/browser/database/database_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698