Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2774413002: Move some blob tests next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some blob tests next to the files they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2774413002 Cr-Commit-Position: refs/heads/master@{#459920} Committed: https://chromium.googlesource.com/chromium/src/+/119e4c228dd58f8b754735f92cb7e31e999e01de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2109 lines) Patch
D content/browser/blob_storage/blob_data_builder_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D content/browser/blob_storage/blob_flattener_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D content/browser/blob_storage/blob_memory_controller_unittest.cc View 1 chunk +0 lines, -1123 lines 0 comments Download
D content/browser/blob_storage/blob_slice_unittest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D content/browser/blob_storage/blob_storage_registry_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D content/browser/blob_storage/blob_transport_request_builder_unittest.cc View 1 chunk +0 lines, -350 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +10 lines, -7 lines 0 comments Download
A + storage/browser/blob/blob_data_builder_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_flattener_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_memory_controller_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_slice_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_storage_registry_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/blob/blob_transport_request_builder_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D storage/browser/crbug653751_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
pwnall
kinuko: PTAL? The diff stats look scary, but I just moved the files over, updated ...
3 years, 8 months ago (2017-03-27 20:25:07 UTC) #4
kinuko
lgtm
3 years, 8 months ago (2017-03-27 22:29:54 UTC) #7
pwnall
On 2017/03/27 22:29:54, kinuko wrote: > lgtm Thank you very much for the quick turnaround!
3 years, 8 months ago (2017-03-27 22:49:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774413002/1
3 years, 8 months ago (2017-03-27 22:50:23 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 22:57:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/119e4c228dd58f8b754735f92cb7...

Powered by Google App Engine
This is Rietveld 408576698