Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2775383003: Move some fileapi tests next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some fileapi tests next to the files they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2775383003 Cr-Commit-Position: refs/heads/master@{#459946} Committed: https://chromium.googlesource.com/chromium/src/+/375c78221f4df786923744d9cc76e66b55775ecb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2473 lines) Patch
D content/browser/fileapi/external_mount_points_unittest.cc View 1 chunk +0 lines, -505 lines 0 comments Download
D content/browser/fileapi/file_system_url_unittest.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D content/browser/fileapi/file_system_usage_cache_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D content/browser/fileapi/isolated_context_unittest.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D content/browser/fileapi/local_file_stream_reader_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D content/browser/fileapi/local_file_stream_writer_unittest.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D content/browser/fileapi/native_file_util_unittest.cc View 1 chunk +0 lines, -409 lines 0 comments Download
D content/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D content/browser/fileapi/timed_task_helper_unittest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M content/test/BUILD.gn View 4 chunks +0 lines, -10 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A + storage/browser/fileapi/external_mount_points_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_url_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_usage_cache_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/isolated_context_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/local_file_stream_reader_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/local_file_stream_writer_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/native_file_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/timed_task_helper_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
pwnall
kinuko: PTAL? This is also a move CL. The diff stats look scary, but I ...
3 years, 8 months ago (2017-03-27 20:29:49 UTC) #6
kinuko
lgtm Thanks for doing this!
3 years, 8 months ago (2017-03-27 22:23:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775383003/1
3 years, 8 months ago (2017-03-27 23:57:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 00:06:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/375c78221f4df786923744d9cc76...

Powered by Google App Engine
This is Rietveld 408576698