Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2775913003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)

Created:
3 years, 9 months ago by Byoungkwon Ko
Modified:
3 years, 8 months ago
Reviewers:
johnchen, gab, stgao
CC:
chromium-reviews, grt+watch_chromium.org, samuong+watch_chromium.org, wfh+watch_chromium.org, pennymac+watch_chromium.org, devtools-reviews_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome BUG=644626 Review-Url: https://codereview.chromium.org/2775913003 Cr-Commit-Position: refs/heads/master@{#466978} Committed: https://chromium.googlesource.com/chromium/src/+/96068d88777070931805401ff26b1cd406c31f22

Patch Set 1 #

Patch Set 2 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/installer/setup/setup_util.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/element_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (15 generated)
Byoungkwon Ko
PTAL
3 years, 8 months ago (2017-04-25 01:43:52 UTC) #10
stgao
+johnchen lgtm for chromedriver
3 years, 8 months ago (2017-04-25 04:04:51 UTC) #12
johnchen
lgtm for chromedriver
3 years, 8 months ago (2017-04-25 04:41:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775913003/20001
3 years, 8 months ago (2017-04-25 05:41:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419443)
3 years, 8 months ago (2017-04-25 05:48:44 UTC) #17
gab
On 2017/04/25 05:48:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-25 14:04:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775913003/20001
3 years, 8 months ago (2017-04-25 14:05:15 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:09:00 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96068d88777070931805401ff26b...

Powered by Google App Engine
This is Rietveld 408576698