chrome/test/chromedriver/session_commands.cc - Issue 2775913003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 2775913003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)

Patch Set: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/session_commands.cc

diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc

index c6777a3dd75f3ec7b93088cb875eea8b2e326011..b86c69288a2d5bded3f5657c23f3e00121bb43f2 100644

--- a/chrome/test/chromedriver/session_commands.cc

+++ b/chrome/test/chromedriver/session_commands.cc

@@ -353,7 +353,7 @@ Status ExecuteGetWindowHandles(Session* session,

it != web_view_ids.end(); ++it) {

window_ids->AppendString(WebViewIdToWindowHandle(*it));

}

- value->reset(window_ids.release());

+ *value = std::move(window_ids);

return Status(kOk);

}