Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4662)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 2775913003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)
Patch Set: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_util.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index 494411fc3dccb86ca25490a1810fab7aecfc3f0e..a9bafc91ee785b5b2bdb63a6ea797df6b402e923 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -5,6 +5,7 @@
#include "chrome/test/chromedriver/capabilities.h"
#include <map>
+#include <utility>
#include "base/bind.h"
#include "base/callback.h"
@@ -111,7 +112,7 @@ Status ParseDeviceName(const std::string& device_name,
status);
}
- capabilities->device_metrics.reset(device->device_metrics.release());
+ capabilities->device_metrics = std::move(device->device_metrics);
// Don't override the user agent if blank (like for notebooks).
if (!device->user_agent.empty())
capabilities->switches.SetSwitch("user-agent", device->user_agent);
« no previous file with comments | « chrome/installer/setup/setup_util.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698