chrome/test/chromedriver/chrome/devtools_client_impl.cc - Issue 2775913003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.cc

Issue 2775913003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)

Patch Set: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/devtools_client_impl.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.cc b/chrome/test/chromedriver/chrome/devtools_client_impl.cc

index 470fe35b06d53322723703d94ff440a422b87e4e..f814d2432f2c2813ccf8ebb4beb7dabbf73668dc 100644

--- a/chrome/test/chromedriver/chrome/devtools_client_impl.cc

+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.cc

@@ -208,7 +208,7 @@ Status DevToolsClientImpl::SendCommandAndGetResultWithTimeout(

return status;

if (!intermediate_result)

return Status(kUnknownError, "inspector response missing result");

- result->reset(intermediate_result.release());

+ *result = std::move(intermediate_result);

return Status(kOk);

}

« no previous file with comments | « chrome/test/chromedriver/capabilities.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | no next file with comments »