Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2775413002: PPC: Declare X format assembler function with opcode list macro (Closed)

Created:
3 years, 9 months ago by Sampson
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Declare X format assembler function with opcode list macro R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2775413002 Cr-Commit-Position: refs/heads/master@{#44241} Committed: https://chromium.googlesource.com/v8/v8/+/367d646a9e1ba6681f9ab5b05dd06ff038e0dd50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -592 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 7 chunks +100 lines, -62 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 23 chunks +0 lines, -417 lines 0 comments Download
M src/ppc/constants-ppc.h View 5 chunks +131 lines, -110 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sampson
Please take a look.
3 years, 8 months ago (2017-03-28 15:13:03 UTC) #1
JaideepBajwa
lgtm
3 years, 8 months ago (2017-03-29 17:17:25 UTC) #2
john.yan
lgtm
3 years, 8 months ago (2017-03-29 17:18:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775413002/1
3 years, 8 months ago (2017-03-29 17:38:58 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:07:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/367d646a9e1ba6681f9ab5b05dd06ff038e...

Powered by Google App Engine
This is Rietveld 408576698