add DCHECK that a server redirect pending item should never be added.

add DCHECK that a server redirect pending item should never be added.

Server side redirects are handled by updating existing pending item
instead of adding a new item. So put a DCHECK in |-addPendingItem| in
CRWSessionController for this.

BUG=

Review-Url: https://codereview.chromium.org/2775023002
Cr-Commit-Position: refs/heads/master@{#459616}
Committed: https://chromium.googlesource.com/chromium/src/+/945f75131dcd40006ad32b0e05e70b9cf9d5bb63

[liaoyuke, 2017-03-24 23:28:16]

The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 23:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liaoyuke, 2017-03-24 23:48:25]

liaoyuke@chromium.org changed reviewers:
+ eugenebut@chromium.org

[liaoyuke, 2017-03-24 23:48:26]

Hey Eugene,

PTAL.

Thank you very much!

[liaoyuke, 2017-03-24 23:54:25]

The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 23:54:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-03-25 00:21:53]

lgtm

[liaoyuke, 2017-03-25 00:40:38]

Patchset #1 (id:1) has been deleted

[liaoyuke, 2017-03-25 00:42:02]

The CQ bit was checked by liaoyuke@chromium.org

[liaoyuke, 2017-03-25 00:42:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2775023002/#ps20001
(title: "")

[commit-bot: I haz the power, 2017-03-25 00:42:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 01:47:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490402522814390,
"parent_rev": "7bbbe81b90df01b601a656744df9d4a6a791fbea", "commit_rev":
"945f75131dcd40006ad32b0e05e70b9cf9d5bb63"}

[commit-bot: I haz the power, 2017-03-25 01:47:59]

Description was changed from

==========
add DCHECK that a server redirect pending item should never be added.

Server side redirects are handled by updating existing pending item
instead of adding a new item. So put a DCHECK in |-addPendingItem| in
CRWSessionController for this.

BUG=
==========

to

==========
add DCHECK that a server redirect pending item should never be added.

Server side redirects are handled by updating existing pending item
instead of adding a new item. So put a DCHECK in |-addPendingItem| in
CRWSessionController for this.

BUG=

Review-Url: https://codereview.chromium.org/2775023002
Cr-Commit-Position: refs/heads/master@{#459616}
Committed:
https://chromium.googlesource.com/chromium/src/+/945f75131dcd40006ad32b0e05e7...
==========

[commit-bot: I haz the power, 2017-03-25 01:48:01]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/945f75131dcd40006ad32b0e05e7...