Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: ios/web/navigation/navigation_manager_impl_unittest.mm

Issue 2775023002: add DCHECK that a server redirect pending item should never be added. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_manager_impl_unittest.mm
diff --git a/ios/web/navigation/navigation_manager_impl_unittest.mm b/ios/web/navigation/navigation_manager_impl_unittest.mm
index 9bc5a3ac7834038a92750ab2d15cec013df52c00..7bac7552ab46256554b5a441339fd7f0aba2b974 100644
--- a/ios/web/navigation/navigation_manager_impl_unittest.mm
+++ b/ios/web/navigation/navigation_manager_impl_unittest.mm
@@ -254,7 +254,7 @@ void OnNavigationItemCommitted(const LoadCommittedDetails&) override {}
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/redirect"), Referrer(),
- ui::PAGE_TRANSITION_IS_REDIRECT_MASK,
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT,
web::NavigationInitiationType::USER_INITIATED);
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
@@ -267,7 +267,7 @@ void OnNavigationItemCommitted(const LoadCommittedDetails&) override {}
[session_controller() commitPendingItem];
navigation_manager()->AddPendingItem(
GURL("http://www.url.com/redirect"), Referrer(),
- ui::PAGE_TRANSITION_IS_REDIRECT_MASK,
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT,
web::NavigationInitiationType::USER_INITIATED);
[session_controller() commitPendingItem];
ASSERT_EQ(5, navigation_manager()->GetItemCount());
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698