Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: ios/chrome/browser/web/navigation_manager_util_unittest.mm

Issue 2775023002: add DCHECK that a server redirect pending item should never be added. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/navigation_manager_util_unittest.mm
diff --git a/ios/chrome/browser/web/navigation_manager_util_unittest.mm b/ios/chrome/browser/web/navigation_manager_util_unittest.mm
index b02466b9cae9a5a7286f88e43861ac3d2f8a7472..da539961ef8a8fe82e61522b5dec1d20f6ee4784 100644
--- a/ios/chrome/browser/web/navigation_manager_util_unittest.mm
+++ b/ios/chrome/browser/web/navigation_manager_util_unittest.mm
@@ -57,15 +57,14 @@
// Tests that when all items are redirects, the first one is returned.
TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemAllRedirects) {
nav_manager_.AddItem(GURL("http://bar.com/redir0"),
- ui::PAGE_TRANSITION_SERVER_REDIRECT);
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
nav_manager_.AddItem(GURL("http://bar.com/redir1"),
ui::PAGE_TRANSITION_CLIENT_REDIRECT);
nav_manager_.AddItem(GURL("http://bar.com/redir2"),
ui::PAGE_TRANSITION_CLIENT_REDIRECT);
web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
ASSERT_TRUE(item);
- EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
- item->GetTransitionType(), ui::PAGE_TRANSITION_SERVER_REDIRECT));
+ EXPECT_EQ(GURL("http://bar.com/redir0"), item->GetURL());
}
// Tests that earlier redirects are not found.
« no previous file with comments | « no previous file | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698