Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: ios/web/navigation/crw_session_controller_unittest.mm

Issue 2775023002: add DCHECK that a server redirect pending item should never be added. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/navigation/navigation_manager_impl_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/navigation/crw_session_controller.h" 5 #import "ios/web/navigation/crw_session_controller.h"
6 6
7 #import <Foundation/Foundation.h> 7 #import <Foundation/Foundation.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 909 matching lines...) Expand 10 before | Expand all | Expand 10 after
920 [session_controller_ commitPendingItem]; 920 [session_controller_ commitPendingItem];
921 [session_controller_ 921 [session_controller_
922 addPendingItem:GURL("http://www.example.com/1") 922 addPendingItem:GURL("http://www.example.com/1")
923 referrer:MakeReferrer("http://www.example.com/b") 923 referrer:MakeReferrer("http://www.example.com/b")
924 transition:ui::PAGE_TRANSITION_LINK 924 transition:ui::PAGE_TRANSITION_LINK
925 initiationType:web::NavigationInitiationType::USER_INITIATED]; 925 initiationType:web::NavigationInitiationType::USER_INITIATED];
926 [session_controller_ commitPendingItem]; 926 [session_controller_ commitPendingItem];
927 [session_controller_ 927 [session_controller_
928 addPendingItem:GURL("http://www.example.com/redirect") 928 addPendingItem:GURL("http://www.example.com/redirect")
929 referrer:MakeReferrer("http://www.example.com/r") 929 referrer:MakeReferrer("http://www.example.com/r")
930 transition:ui::PAGE_TRANSITION_IS_REDIRECT_MASK 930 transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT
931 initiationType:web::NavigationInitiationType::USER_INITIATED]; 931 initiationType:web::NavigationInitiationType::USER_INITIATED];
932 [session_controller_ commitPendingItem]; 932 [session_controller_ commitPendingItem];
933 [session_controller_ 933 [session_controller_
934 addPendingItem:GURL("http://www.example.com/2") 934 addPendingItem:GURL("http://www.example.com/2")
935 referrer:MakeReferrer("http://www.example.com/c") 935 referrer:MakeReferrer("http://www.example.com/c")
936 transition:ui::PAGE_TRANSITION_LINK 936 transition:ui::PAGE_TRANSITION_LINK
937 initiationType:web::NavigationInitiationType::USER_INITIATED]; 937 initiationType:web::NavigationInitiationType::USER_INITIATED];
938 [session_controller_ commitPendingItem]; 938 [session_controller_ commitPendingItem];
939 939
940 EXPECT_EQ(3, session_controller_.get().lastCommittedItemIndex); 940 EXPECT_EQ(3, session_controller_.get().lastCommittedItemIndex);
(...skipping 23 matching lines...) Expand all
964 [session_controller_ commitPendingItem]; 964 [session_controller_ commitPendingItem];
965 [session_controller_ 965 [session_controller_
966 addPendingItem:GURL("http://www.example.com/1") 966 addPendingItem:GURL("http://www.example.com/1")
967 referrer:MakeReferrer("http://www.example.com/b") 967 referrer:MakeReferrer("http://www.example.com/b")
968 transition:ui::PAGE_TRANSITION_LINK 968 transition:ui::PAGE_TRANSITION_LINK
969 initiationType:web::NavigationInitiationType::USER_INITIATED]; 969 initiationType:web::NavigationInitiationType::USER_INITIATED];
970 [session_controller_ commitPendingItem]; 970 [session_controller_ commitPendingItem];
971 [session_controller_ 971 [session_controller_
972 addPendingItem:GURL("http://www.example.com/redirect") 972 addPendingItem:GURL("http://www.example.com/redirect")
973 referrer:MakeReferrer("http://www.example.com/r") 973 referrer:MakeReferrer("http://www.example.com/r")
974 transition:ui::PAGE_TRANSITION_IS_REDIRECT_MASK 974 transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT
975 initiationType:web::NavigationInitiationType::USER_INITIATED]; 975 initiationType:web::NavigationInitiationType::USER_INITIATED];
976 [session_controller_ commitPendingItem]; 976 [session_controller_ commitPendingItem];
977 [session_controller_ 977 [session_controller_
978 addPendingItem:GURL("http://www.example.com/2") 978 addPendingItem:GURL("http://www.example.com/2")
979 referrer:MakeReferrer("http://www.example.com/c") 979 referrer:MakeReferrer("http://www.example.com/c")
980 transition:ui::PAGE_TRANSITION_LINK 980 transition:ui::PAGE_TRANSITION_LINK
981 initiationType:web::NavigationInitiationType::USER_INITIATED]; 981 initiationType:web::NavigationInitiationType::USER_INITIATED];
982 [session_controller_ commitPendingItem]; 982 [session_controller_ commitPendingItem];
983 [session_controller_ 983 [session_controller_
984 addPendingItem:GURL("http://www.example.com/3") 984 addPendingItem:GURL("http://www.example.com/3")
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1145 [session_controller_ 1145 [session_controller_
1146 addPendingItem:GURL("http://www.example.com/0") 1146 addPendingItem:GURL("http://www.example.com/0")
1147 referrer:MakeReferrer("http://www.example.com/b") 1147 referrer:MakeReferrer("http://www.example.com/b")
1148 transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT 1148 transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT
1149 initiationType:web::NavigationInitiationType::RENDERER_INITIATED]; 1149 initiationType:web::NavigationInitiationType::RENDERER_INITIATED];
1150 [session_controller_ commitPendingItem]; 1150 [session_controller_ commitPendingItem];
1151 EXPECT_EQ(0U, [session_controller_ backwardItems].size()); 1151 EXPECT_EQ(0U, [session_controller_ backwardItems].size());
1152 } 1152 }
1153 1153
1154 } // anonymous namespace 1154 } // anonymous namespace
OLDNEW
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/navigation/navigation_manager_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698