Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (patchset #2 id:100001 of https://codereview.chromium.org/2765723002/ )

Reason for revert:
Breaks on MSAN: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/879

Original issue's description:
> RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> Original CL got reverted due to shapedetection/detection-on-worker.html
> fail to fetch source for module skia/public/interfaces/bitmap.mojom.
> 
> This CL add gen/skia/public/interfaces to generated bindings paths.
> 
> Original CL description ------------------------------------------------
> ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
> so that the Detect API is completely flexible and friendly.
> 
> BUG=665488
> TEST(Layout)=
>  third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
>  third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
> 
> Review-Url: https://codereview.chromium.org/2629433003
> Cr-Commit-Position: refs/heads/master@{#446142}
> (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)
> 
> Conflicts:
> 	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
> 	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org
> since the gist of the CL hasn't changed.
> 
> Review-Url: https://codereview.chromium.org/2681913003
> Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
> Review-Url: https://codereview.chromium.org/2753413002
> Cr-Original-Commit-Position: refs/heads/master@{#458010}
> Review-Url: https://codereview.chromium.org/2765723002
> Cr-Commit-Position: refs/heads/master@{#458657}
> Committed: https://chromium.googlesource.com/chromium/src/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8

TBR=bsalomon@google.com,dtrainor@chromium.org,haraken@chromium.org,rockot@chromium.org,tsepez@chromium.org,dpranke@chromium.org,mcasas@chromium.org,junwei.fu@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665488

[dgozman, 2017-03-22 23:59:20]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-22 23:59:21]

Created Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

[commit-bot: I haz the power, 2017-03-23 00:00:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:02:56]

Failed to apply patch for content/public/android/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: content/public/android/BUILD.gn:60
  error: content/public/android/BUILD.gn: patch does not apply

Patch:       content/public/android/BUILD.gn
Index: content/public/android/BUILD.gn
diff --git a/content/public/android/BUILD.gn b/content/public/android/BUILD.gn
index
e2889e6a77e04e5bd045632eb8837ff2b017ba83..d9ed24d69efd9f8450469c6cf8d7f13d0c15b9e0
100644
--- a/content/public/android/BUILD.gn
+++ b/content/public/android/BUILD.gn
@@ -60,7 +60,6 @@
     "//services/service_manager/public/interfaces:interfaces_java",
     "//services/service_manager/public/java:service_manager_java",
     "//services/shape_detection/public/interfaces:interfaces_java",
-    "//skia/public/interfaces:interfaces_java",
     "//third_party/WebKit/public:blink_headers_java",
     "//third_party/WebKit/public:mojo_bindings_java",
     "//third_party/android_tools:android_support_annotations_java",

[Ken Rockot(use gerrit already), 2017-03-24 21:23:00]

Description was changed from

==========
Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
(patchset #2 id:100001 of https://codereview.chromium.org/2765723002/ )

Reason for revert:
Breaks on MSAN:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...

Original issue's description:
> RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> Original CL got reverted due to shapedetection/detection-on-worker.html
> fail to fetch source for module skia/public/interfaces/bitmap.mojom.
> 
> This CL add gen/skia/public/interfaces to generated bindings paths.
> 
> Original CL description ------------------------------------------------
> ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
> so that the Detect API is completely flexible and friendly.
> 
> BUG=665488
> TEST(Layout)=
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
> 
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
> 
> Review-Url: https://codereview.chromium.org/2629433003
> Cr-Commit-Position: refs/heads/master@{#446142}
> (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)
> 
> Conflicts:
> 	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
> 	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
> since the gist of the CL hasn't changed.
> 
> Review-Url: https://codereview.chromium.org/2681913003
> Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
> Review-Url: https://codereview.chromium.org/2753413002
> Cr-Original-Commit-Position: refs/heads/master@{#458010}
> Review-Url: https://codereview.chromium.org/2765723002
> Cr-Commit-Position: refs/heads/master@{#458657}
> Committed:
https://chromium.googlesource.com/chromium/src/+/11a82c3aaabd39fc3a0981a6e66b...

TBR=bsalomon@google.com,dtrainor@chromium.org,haraken@chromium.org,rockot@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665488
==========

to

==========
Revert of RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
(patchset #2 id:100001 of https://codereview.chromium.org/2765723002/ )

Reason for revert:
Breaks on MSAN:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...

Original issue's description:
> RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> Original CL got reverted due to shapedetection/detection-on-worker.html
> fail to fetch source for module skia/public/interfaces/bitmap.mojom.
> 
> This CL add gen/skia/public/interfaces to generated bindings paths.
> 
> Original CL description ------------------------------------------------
> ShapeDetection: use mojom::Bitmap for mojo interface.
> 
> This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
> so that the Detect API is completely flexible and friendly.
> 
> BUG=665488
> TEST(Layout)=
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
> 
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
> 
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
>  third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
> 
> Review-Url: https://codereview.chromium.org/2629433003
> Cr-Commit-Position: refs/heads/master@{#446142}
> (cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)
> 
> Conflicts:
> 	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
> 	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> 
> TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org,
bsalomon@google.com, tsepez@chromium.org
> since the gist of the CL hasn't changed.
> 
> Review-Url: https://codereview.chromium.org/2681913003
> Cr-Original-Original-Commit-Position: refs/heads/master@{#450582}
> Review-Url: https://codereview.chromium.org/2753413002
> Cr-Original-Commit-Position: refs/heads/master@{#458010}
> Review-Url: https://codereview.chromium.org/2765723002
> Cr-Commit-Position: refs/heads/master@{#458657}
> Committed:
https://chromium.googlesource.com/chromium/src/+/11a82c3aaabd39fc3a0981a6e66b...

TBR=bsalomon@google.com,dtrainor@chromium.org,haraken@chromium.org,rockot@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665488
==========

[Ken Rockot(use gerrit already), 2017-03-24 21:23:00]

rockot@chromium.org changed reviewers:
- rockot@chromium.org

[mcasas, 2017-03-28 16:44:53]

On 2017/03/23 00:02:56, commit-bot: I haz the power wrote:
> Failed to apply patch for content/public/android/BUILD.gn:
> While running git apply --index -p1;
>   error: patch failed: content/public/android/BUILD.gn:60
>   error: content/public/android/BUILD.gn: patch does not apply
> 
> Patch:       content/public/android/BUILD.gn
> Index: content/public/android/BUILD.gn
> diff --git a/content/public/android/BUILD.gn b/content/public/android/BUILD.gn
> index
>
e2889e6a77e04e5bd045632eb8837ff2b017ba83..d9ed24d69efd9f8450469c6cf8d7f13d0c15b9e0
> 100644
> --- a/content/public/android/BUILD.gn
> +++ b/content/public/android/BUILD.gn
> @@ -60,7 +60,6 @@
>      "//services/service_manager/public/interfaces:interfaces_java",
>      "//services/service_manager/public/java:service_manager_java",
>      "//services/shape_detection/public/interfaces:interfaces_java",
> -    "//skia/public/interfaces:interfaces_java",
>      "//third_party/WebKit/public:blink_headers_java",
>      "//third_party/WebKit/public:mojo_bindings_java",
>      "//third_party/android_tools:android_support_annotations_java",

I think we can close this issue now:
https://bugs.chromium.org/p/chromium/issues/detail?id=665488#c17