Form validation: Validation bubble should be closed on document unload process.

Form validation: Validation bubble should be closed on document unload process.

This CL fixes a bug that a validation bubble is not closed by page navigation in
some cases.

We close a validation message on Page::documentDetached(). However it seems it was
too late to communicate with the browser process in some cases. So, this CL moves
it to Document unload timing.


 * Add ValidationMessage::willUnloadDocument(), which closes a validation bubble,
  and Document::dispatchUnloadEvents() calls it indirectly through Page.

 * HTMLFormControlElement prevents from showing a validation message after the
  unload processing.


BUG=704560
Review-Url: https://codereview.chromium.org/2771193002
Cr-Commit-Position: refs/heads/master@{#459701}
Committed: https://chromium.googlesource.com/chromium/src/+/a896ff44a395a50ab18f5120f20b7eb5a9550247

[tkent, 2017-03-24 06:52:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 06:53:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-24 07:19:34]

Description was changed from

==========
Form validation: Validation bubble should be closed on document unload process.

BUG=
==========

to

==========
Form validation: Validation bubble should be closed on document unload process.

This CL fixes a bug that a validation bubble is not closed by page navigation in
some cases.

We close a validation message on Page::documentDetached(). However it seems it
was
too late to communicate with the browser process in some cases. So, this CL
moves
it to Document unload timing.


 * Add ValidationMessage::willUnloadDocument(), which closes a validation
bubble,
  and Document::dispatchUnloadEvents() calls it.

 * HTMLFormControlElement prevents from showing a validation message after the
  unload processing.


BUG=704560
==========

[commit-bot: I haz the power, 2017-03-24 07:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 07:21:29]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tkent, 2017-03-24 08:05:42]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 08:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-24 08:06:16]

Patchset #1 (id:1) has been deleted

[tkent, 2017-03-24 08:06:30]

Description was changed from

==========
Form validation: Validation bubble should be closed on document unload process.

This CL fixes a bug that a validation bubble is not closed by page navigation in
some cases.

We close a validation message on Page::documentDetached(). However it seems it
was
too late to communicate with the browser process in some cases. So, this CL
moves
it to Document unload timing.


 * Add ValidationMessage::willUnloadDocument(), which closes a validation
bubble,
  and Document::dispatchUnloadEvents() calls it.

 * HTMLFormControlElement prevents from showing a validation message after the
  unload processing.


BUG=704560
==========

to

==========
Form validation: Validation bubble should be closed on document unload process.

This CL fixes a bug that a validation bubble is not closed by page navigation in
some cases.

We close a validation message on Page::documentDetached(). However it seems it
was
too late to communicate with the browser process in some cases. So, this CL
moves
it to Document unload timing.


 * Add ValidationMessage::willUnloadDocument(), which closes a validation
bubble,
  and Document::dispatchUnloadEvents() calls it indirectly through Page.

 * HTMLFormControlElement prevents from showing a validation message after the
  unload processing.


BUG=704560
==========

[tkent, 2017-03-24 08:07:38]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2017-03-24 08:07:39]

keishi@, would you review this please?

[commit-bot: I haz the power, 2017-03-24 10:14:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 10:14:12]

Dry run: This issue passed the CQ dry run.

[keishi, 2017-03-27 01:21:24]

LGTM

[tkent, 2017-03-27 01:22:14]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-27 01:22:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 02:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 02:32:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-03-27 03:00:29]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-27 03:00:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 03:47:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490583629433970,
"parent_rev": "117a5ba5073a1c78d08d3be3210afc09af96158c", "commit_rev":
"a896ff44a395a50ab18f5120f20b7eb5a9550247"}

[commit-bot: I haz the power, 2017-03-27 03:48:11]

Description was changed from

==========
Form validation: Validation bubble should be closed on document unload process.

This CL fixes a bug that a validation bubble is not closed by page navigation in
some cases.

We close a validation message on Page::documentDetached(). However it seems it
was
too late to communicate with the browser process in some cases. So, this CL
moves
it to Document unload timing.


 * Add ValidationMessage::willUnloadDocument(), which closes a validation
bubble,
  and Document::dispatchUnloadEvents() calls it indirectly through Page.

 * HTMLFormControlElement prevents from showing a validation message after the
  unload processing.


BUG=704560
==========

to

==========
Form validation: Validation bubble should be closed on document unload process.

This CL fixes a bug that a validation bubble is not closed by page navigation in
some cases.

We close a validation message on Page::documentDetached(). However it seems it
was
too late to communicate with the browser process in some cases. So, this CL
moves
it to Document unload timing.


 * Add ValidationMessage::willUnloadDocument(), which closes a validation
bubble,
  and Document::dispatchUnloadEvents() calls it indirectly through Page.

 * HTMLFormControlElement prevents from showing a validation message after the
  unload processing.


BUG=704560

Review-Url: https://codereview.chromium.org/2771193002
Cr-Commit-Position: refs/heads/master@{#459701}
Committed:
https://chromium.googlesource.com/chromium/src/+/a896ff44a395a50ab18f5120f20b...
==========

[commit-bot: I haz the power, 2017-03-27 03:48:12]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a896ff44a395a50ab18f5120f20b...