third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 2771193002: Form validation: Validation bubble should be closed on document unload process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2771193002: Form validation: Validation bubble should be closed on document unload process. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index c30ad8b23aec88f26e836c784223b0b29ef4f54f..f0e9aa5aa7362eb0112d1dce3518832663939ab4 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -461,7 +461,7 @@ void HTMLFormControlElement::findCustomValidationMessageTextDirection(

void HTMLFormControlElement::updateVisibleValidationMessage() {

Page* page = document().page();

- if (!page || !page->isPageVisible())

+ if (!page || !page->isPageVisible() || document().unloadStarted())

return;

String message;

if (layoutObject() && willValidate())