Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2771193002: Form validation: Validation bubble should be closed on document unload process. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All
3 * Rights Reserved. 3 * Rights Reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 236
237 void Page::setMainFrame(Frame* mainFrame) { 237 void Page::setMainFrame(Frame* mainFrame) {
238 // Should only be called during initialization or swaps between local and 238 // Should only be called during initialization or swaps between local and
239 // remote frames. 239 // remote frames.
240 // FIXME: Unfortunately we can't assert on this at the moment, because this 240 // FIXME: Unfortunately we can't assert on this at the moment, because this
241 // is called in the base constructor for both LocalFrame and RemoteFrame, 241 // is called in the base constructor for both LocalFrame and RemoteFrame,
242 // when the vtables for the derived classes have not yet been setup. 242 // when the vtables for the derived classes have not yet been setup.
243 m_mainFrame = mainFrame; 243 m_mainFrame = mainFrame;
244 } 244 }
245 245
246 void Page::willUnloadDocument(const Document& document) {
247 if (m_validationMessageClient)
248 m_validationMessageClient->willUnloadDocument(document);
249 }
250
246 void Page::documentDetached(Document* document) { 251 void Page::documentDetached(Document* document) {
247 m_pointerLockController->documentDetached(document); 252 m_pointerLockController->documentDetached(document);
248 m_contextMenuController->documentDetached(document); 253 m_contextMenuController->documentDetached(document);
249 if (m_validationMessageClient) 254 if (m_validationMessageClient)
250 m_validationMessageClient->documentDetached(*document); 255 m_validationMessageClient->documentDetached(*document);
251 m_hostsUsingFeatures.documentDetached(*document); 256 m_hostsUsingFeatures.documentDetached(*document);
252 } 257 }
253 258
254 bool Page::openedByDOM() const { 259 bool Page::openedByDOM() const {
255 return m_openedByDOM; 260 return m_openedByDOM;
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 : chromeClient(nullptr), 669 : chromeClient(nullptr),
665 contextMenuClient(nullptr), 670 contextMenuClient(nullptr),
666 editorClient(nullptr), 671 editorClient(nullptr),
667 spellCheckerClient(nullptr) {} 672 spellCheckerClient(nullptr) {}
668 673
669 Page::PageClients::~PageClients() {} 674 Page::PageClients::~PageClients() {}
670 675
671 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 676 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
672 677
673 } // namespace blink 678 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/core/page/ValidationMessageClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698