Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2771193002: Form validation: Validation bubble should be closed on document unload process. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 TextDirection& messageDir, 454 TextDirection& messageDir,
455 String& subMessage, 455 String& subMessage,
456 TextDirection& subMessageDir) { 456 TextDirection& subMessageDir) {
457 messageDir = determineDirectionality(message); 457 messageDir = determineDirectionality(message);
458 if (!subMessage.isEmpty()) 458 if (!subMessage.isEmpty())
459 subMessageDir = layoutObject()->style()->direction(); 459 subMessageDir = layoutObject()->style()->direction();
460 } 460 }
461 461
462 void HTMLFormControlElement::updateVisibleValidationMessage() { 462 void HTMLFormControlElement::updateVisibleValidationMessage() {
463 Page* page = document().page(); 463 Page* page = document().page();
464 if (!page || !page->isPageVisible()) 464 if (!page || !page->isPageVisible() || document().unloadStarted())
465 return; 465 return;
466 String message; 466 String message;
467 if (layoutObject() && willValidate()) 467 if (layoutObject() && willValidate())
468 message = validationMessage().stripWhiteSpace(); 468 message = validationMessage().stripWhiteSpace();
469 469
470 m_hasValidationMessage = true; 470 m_hasValidationMessage = true;
471 ValidationMessageClient* client = &page->validationMessageClient(); 471 ValidationMessageClient* client = &page->validationMessageClient();
472 TextDirection messageDir = TextDirection::kLtr; 472 TextDirection messageDir = TextDirection::kLtr;
473 TextDirection subMessageDir = TextDirection::kLtr; 473 TextDirection subMessageDir = TextDirection::kLtr;
474 String subMessage = validationSubMessage().stripWhiteSpace(); 474 String subMessage = validationSubMessage().stripWhiteSpace();
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 const Element& source) { 635 const Element& source) {
636 HTMLElement::copyNonAttributePropertiesFromElement(source); 636 HTMLElement::copyNonAttributePropertiesFromElement(source);
637 setNeedsValidityCheck(); 637 setNeedsValidityCheck();
638 } 638 }
639 639
640 void HTMLFormControlElement::associateWith(HTMLFormElement* form) { 640 void HTMLFormControlElement::associateWith(HTMLFormElement* form) {
641 associateByParser(form); 641 associateByParser(form);
642 }; 642 };
643 643
644 } // namespace blink 644 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentTest.cpp ('k') | third_party/WebKit/Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698