Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 2770733002: Reland of Show Overlay Scrollbar when GestureScrollUpdate (Closed)

Created:
3 years, 9 months ago by chaopeng
Modified:
3 years, 9 months ago
Reviewers:
bokan, pdr., weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Show Overlay Scrollbar when GestureScrollUpdate (patchset #2 id:160001 of https://codereview.chromium.org/2748343004/ ) Fix for GPU memory issue: This issue is caused by more than one DelayedFadeOut task posted. So we cancel the previous task before we post a new one. Original issue's description: > Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10 id:260001 of https://codereview.chromium.org/2611013002/ ) > > Reason for revert: > memory regression: crbug.com/701810 > > Original issue's description: > > Show Overlay Scrollbar when GestureScrollUpdate > > > > Currently, we only show overlay scrollbars once the page/scroller actually > > changes position. In this patch, I also call the > > WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can > > show scrollbar when we receive scroll gestures. > > > > BUG=675594 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > > > Review-Url: https://codereview.chromium.org/2611013002 > > Cr-Commit-Position: refs/heads/master@{#456474} > > Committed: https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3782c10513fab > > TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=675594 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2748343004 > Cr-Commit-Position: refs/heads/master@{#457334} > Committed: https://chromium.googlesource.com/chromium/src/+/c7a846538699afcb05ba89a8dd8abbf5bbc418ab TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=675594 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2770733002 Cr-Commit-Position: refs/heads/master@{#459077} Committed: https://chromium.googlesource.com/chromium/src/+/fddbf72985cda9f23f0416c6e6eb1c7714825656

Patch Set 1 #

Patch Set 2 : fix for gpu memory issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -78 lines) Patch
M cc/input/scrollbar_animation_controller.h View 1 3 chunks +14 lines, -2 lines 0 comments Download
M cc/input/scrollbar_animation_controller.cc View 1 7 chunks +42 lines, -20 lines 0 comments Download
M cc/input/scrollbar_animation_controller_unittest.cc View 1 44 chunks +96 lines, -46 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +25 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 4 chunks +34 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
chaopeng
Created Reland of Show Overlay Scrollbar when GestureScrollUpdate
3 years, 9 months ago (2017-03-22 18:49:35 UTC) #2
chaopeng
PTAL. Thank you.
3 years, 9 months ago (2017-03-22 18:58:28 UTC) #8
bokan
Please describe in the commit message what the fix for the memory regression is. Otherwise, ...
3 years, 9 months ago (2017-03-22 19:18:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770733002/180001
3 years, 9 months ago (2017-03-23 14:17:51 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 14:25:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/fddbf72985cda9f23f0416c6e6eb...

Powered by Google App Engine
This is Rietveld 408576698