Revert of Show Overlay Scrollbar when GestureScrollUpdate

Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10 id:260001 of https://codereview.chromium.org/2611013002/ )

Reason for revert:
memory regression: crbug.com/701810

Original issue's description:
> Show Overlay Scrollbar when GestureScrollUpdate
> 
> Currently, we only show overlay scrollbars once the page/scroller actually 
> changes position. In this patch, I also call the 
> WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
>  show scrollbar when we receive scroll gestures.
> 
> BUG=675594
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2611013002
> Cr-Commit-Position: refs/heads/master@{#456474}
> Committed: https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3782c10513fab

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2748343004
Cr-Commit-Position: refs/heads/master@{#457334}
Committed: https://chromium.googlesource.com/chromium/src/+/c7a846538699afcb05ba89a8dd8abbf5bbc418ab

[chaopeng, 2017-03-15 21:32:40]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-03-15 21:32:41]

Created Revert of Show Overlay Scrollbar when GestureScrollUpdate

[commit-bot: I haz the power, 2017-03-15 21:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:33:55]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[bokan, 2017-03-15 21:37:44]

On 2017/03/15 21:33:55, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet.
> CQ run can only be started once the patch has received an L-G-T-M from a full
> committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
> full super star committer.
> Committers are members of the group "project-chromium-committers".
> Note that this has nothing to do with OWNERS files.

Lgtm

[bokan, 2017-03-15 21:37:57]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:38:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:09:39]

Failed to apply patch for cc/input/scrollbar_animation_controller.cc:
While running git apply --index -p1;
  error: patch failed: cc/input/scrollbar_animation_controller.cc:168
  error: cc/input/scrollbar_animation_controller.cc: patch does not apply

Patch:       cc/input/scrollbar_animation_controller.cc
Index: cc/input/scrollbar_animation_controller.cc
diff --git a/cc/input/scrollbar_animation_controller.cc
b/cc/input/scrollbar_animation_controller.cc
index
da3ba8a2e204235b935a5fa88d0dc97c5c5ff269..4906ef4737db1921018b018ad1b8243652714805
100644
--- a/cc/input/scrollbar_animation_controller.cc
+++ b/cc/input/scrollbar_animation_controller.cc
@@ -53,7 +53,6 @@
       scroll_gesture_has_scrolled_(false),
       opacity_(0.0f),
       fade_out_duration_(fade_out_duration),
-      show_scrollbars_on_scroll_gesture_(false),
       need_thinning_animation_(false),
       weak_factory_(this) {
   ApplyOpacityToScrollbars(0.0f);
@@ -78,7 +77,6 @@
       scroll_gesture_has_scrolled_(false),
       opacity_(0.0f),
       fade_out_duration_(fade_out_duration),
-      show_scrollbars_on_scroll_gesture_(true),
       need_thinning_animation_(true),
       weak_factory_(this) {
   vertical_controller_ = SingleScrollbarAnimationControllerThinning::Create(
@@ -168,6 +166,10 @@
   return std::max(std::min(progress, 1.f), 0.f);
 }
 
+void ScrollbarAnimationController::DidScrollBegin() {
+  currently_scrolling_ = true;
+}
+
 void ScrollbarAnimationController::RunAnimationFrame(float progress) {
   ApplyOpacityToScrollbars(1.f - progress);
   client_->SetNeedsRedrawForScrollbarAnimation();
@@ -175,26 +177,7 @@
     StopAnimation();
 }
 
-void ScrollbarAnimationController::DidScrollBegin() {
-  currently_scrolling_ = true;
-}
-
-void ScrollbarAnimationController::DidScrollEnd() {
-  bool has_scrolled = scroll_gesture_has_scrolled_;
-  scroll_gesture_has_scrolled_ = false;
-
-  currently_scrolling_ = false;
-
-  // We don't fade out scrollbar if they need thinning animation and mouse is
-  // near.
-  if (need_thinning_animation_ && MouseIsNearAnyScrollbar())
-    return;
-
-  if (has_scrolled)
-    PostDelayedFadeOut(false);
-}
-
-void ScrollbarAnimationController::DidScrollUpdate() {
+void ScrollbarAnimationController::DidScrollUpdate(bool on_resize) {
   if (need_thinning_animation_ && Captured())
     return;
 
@@ -206,7 +189,7 @@
     // We don't fade out scrollbar if they need thinning animation and mouse is
     // near.
     if (!need_thinning_animation_ || !MouseIsNearAnyScrollbar())
-      PostDelayedFadeOut(false);
+      PostDelayedFadeOut(on_resize);
   } else {
     scroll_gesture_has_scrolled_ = true;
   }
@@ -219,17 +202,19 @@
   }
 }
 
-void ScrollbarAnimationController::WillUpdateScroll() {
-  if (show_scrollbars_on_scroll_gesture_)
-    DidScrollUpdate();
-}
-
-void ScrollbarAnimationController::DidResize() {
-  StopAnimation();
-  Show();
-  // We should use the gesture delay rather than the resize delay if we're in a
-  // gesture scroll, even if it is resizing.
-  PostDelayedFadeOut(!currently_scrolling_);
+void ScrollbarAnimationController::DidScrollEnd() {
+  bool has_scrolled = scroll_gesture_has_scrolled_;
+  scroll_gesture_has_scrolled_ = false;
+
+  currently_scrolling_ = false;
+
+  // We don't fade out scrollbar if they need thinning animation and mouse is
+  // near.
+  if (need_thinning_animation_ && MouseIsNearAnyScrollbar())
+    return;
+
+  if (has_scrolled)
+    PostDelayedFadeOut(false);
 }
 
 void ScrollbarAnimationController::DidMouseDown() {

[chaopeng, 2017-03-15 23:54:23]

The CQ bit was checked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:55:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:03:48]

Failed to apply patch for cc/input/scrollbar_animation_controller.cc:
While running git apply --index -p1;
  error: patch failed: cc/input/scrollbar_animation_controller.cc:168
  error: cc/input/scrollbar_animation_controller.cc: patch does not apply

Patch:       cc/input/scrollbar_animation_controller.cc
Index: cc/input/scrollbar_animation_controller.cc
diff --git a/cc/input/scrollbar_animation_controller.cc
b/cc/input/scrollbar_animation_controller.cc
index
da3ba8a2e204235b935a5fa88d0dc97c5c5ff269..4906ef4737db1921018b018ad1b8243652714805
100644
--- a/cc/input/scrollbar_animation_controller.cc
+++ b/cc/input/scrollbar_animation_controller.cc
@@ -53,7 +53,6 @@
       scroll_gesture_has_scrolled_(false),
       opacity_(0.0f),
       fade_out_duration_(fade_out_duration),
-      show_scrollbars_on_scroll_gesture_(false),
       need_thinning_animation_(false),
       weak_factory_(this) {
   ApplyOpacityToScrollbars(0.0f);
@@ -78,7 +77,6 @@
       scroll_gesture_has_scrolled_(false),
       opacity_(0.0f),
       fade_out_duration_(fade_out_duration),
-      show_scrollbars_on_scroll_gesture_(true),
       need_thinning_animation_(true),
       weak_factory_(this) {
   vertical_controller_ = SingleScrollbarAnimationControllerThinning::Create(
@@ -168,6 +166,10 @@
   return std::max(std::min(progress, 1.f), 0.f);
 }
 
+void ScrollbarAnimationController::DidScrollBegin() {
+  currently_scrolling_ = true;
+}
+
 void ScrollbarAnimationController::RunAnimationFrame(float progress) {
   ApplyOpacityToScrollbars(1.f - progress);
   client_->SetNeedsRedrawForScrollbarAnimation();
@@ -175,26 +177,7 @@
     StopAnimation();
 }
 
-void ScrollbarAnimationController::DidScrollBegin() {
-  currently_scrolling_ = true;
-}
-
-void ScrollbarAnimationController::DidScrollEnd() {
-  bool has_scrolled = scroll_gesture_has_scrolled_;
-  scroll_gesture_has_scrolled_ = false;
-
-  currently_scrolling_ = false;
-
-  // We don't fade out scrollbar if they need thinning animation and mouse is
-  // near.
-  if (need_thinning_animation_ && MouseIsNearAnyScrollbar())
-    return;
-
-  if (has_scrolled)
-    PostDelayedFadeOut(false);
-}
-
-void ScrollbarAnimationController::DidScrollUpdate() {
+void ScrollbarAnimationController::DidScrollUpdate(bool on_resize) {
   if (need_thinning_animation_ && Captured())
     return;
 
@@ -206,7 +189,7 @@
     // We don't fade out scrollbar if they need thinning animation and mouse is
     // near.
     if (!need_thinning_animation_ || !MouseIsNearAnyScrollbar())
-      PostDelayedFadeOut(false);
+      PostDelayedFadeOut(on_resize);
   } else {
     scroll_gesture_has_scrolled_ = true;
   }
@@ -219,17 +202,19 @@
   }
 }
 
-void ScrollbarAnimationController::WillUpdateScroll() {
-  if (show_scrollbars_on_scroll_gesture_)
-    DidScrollUpdate();
-}
-
-void ScrollbarAnimationController::DidResize() {
-  StopAnimation();
-  Show();
-  // We should use the gesture delay rather than the resize delay if we're in a
-  // gesture scroll, even if it is resizing.
-  PostDelayedFadeOut(!currently_scrolling_);
+void ScrollbarAnimationController::DidScrollEnd() {
+  bool has_scrolled = scroll_gesture_has_scrolled_;
+  scroll_gesture_has_scrolled_ = false;
+
+  currently_scrolling_ = false;
+
+  // We don't fade out scrollbar if they need thinning animation and mouse is
+  // near.
+  if (need_thinning_animation_ && MouseIsNearAnyScrollbar())
+    return;
+
+  if (has_scrolled)
+    PostDelayedFadeOut(false);
 }
 
 void ScrollbarAnimationController::DidMouseDown() {

[chaopeng, 2017-03-16 02:16:28]

Description was changed from

==========
Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10
id:260001 of https://codereview.chromium.org/2611013002/ )

Reason for revert:
memory regression: crbug.com/701810

Original issue's description:
> Show Overlay Scrollbar when GestureScrollUpdate
> 
> Currently, we only show overlay scrollbars once the page/scroller actually 
> changes position. In this patch, I also call the 
> WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we
can
>  show scrollbar when we receive scroll gestures.
> 
> BUG=675594
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2611013002
> Cr-Commit-Position: refs/heads/master@{#456474}
> Committed:
https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3...

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675594
==========

to

==========
Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10
id:260001 of https://codereview.chromium.org/2611013002/ )

Reason for revert:
memory regression: crbug.com/701810

Original issue's description:
> Show Overlay Scrollbar when GestureScrollUpdate
> 
> Currently, we only show overlay scrollbars once the page/scroller actually 
> changes position. In this patch, I also call the 
> WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we
can
>  show scrollbar when we receive scroll gestures.
> 
> BUG=675594
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2611013002
> Cr-Commit-Position: refs/heads/master@{#456474}
> Committed:
https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3...

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-03-16 02:16:43]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-03-16 02:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2748343004/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-16 02:17:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 03:16:13]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1489630603224890,
"parent_rev": "0f09ac38e0b5691000cabd182fe0416c7e586af7", "commit_rev":
"c7a846538699afcb05ba89a8dd8abbf5bbc418ab"}

[commit-bot: I haz the power, 2017-03-16 03:17:48]

Description was changed from

==========
Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10
id:260001 of https://codereview.chromium.org/2611013002/ )

Reason for revert:
memory regression: crbug.com/701810

Original issue's description:
> Show Overlay Scrollbar when GestureScrollUpdate
> 
> Currently, we only show overlay scrollbars once the page/scroller actually 
> changes position. In this patch, I also call the 
> WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we
can
>  show scrollbar when we receive scroll gestures.
> 
> BUG=675594
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2611013002
> Cr-Commit-Position: refs/heads/master@{#456474}
> Committed:
https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3...

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10
id:260001 of https://codereview.chromium.org/2611013002/ )

Reason for revert:
memory regression: crbug.com/701810

Original issue's description:
> Show Overlay Scrollbar when GestureScrollUpdate
> 
> Currently, we only show overlay scrollbars once the page/scroller actually 
> changes position. In this patch, I also call the 
> WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we
can
>  show scrollbar when we receive scroll gestures.
> 
> BUG=675594
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2611013002
> Cr-Commit-Position: refs/heads/master@{#456474}
> Committed:
https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3...

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2748343004
Cr-Commit-Position: refs/heads/master@{#457334}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7a846538699afcb05ba89a8dd8a...
==========

[commit-bot: I haz the power, 2017-03-16 03:17:49]

Committed patchset #2 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/c7a846538699afcb05ba89a8dd8a...

[chaopeng, 2017-03-16 18:25:09]

A revert of this CL (patchset #2 id:160001) has been created in
https://codereview.chromium.org/2753083002/ by chaopeng@chromium.org.

The reason for reverting is: Reland.

[chaopeng, 2017-03-22 18:49:35]

A revert of this CL (patchset #2 id:160001) has been created in
https://codereview.chromium.org/2770733002/ by chaopeng@chromium.org.

The reason for reverting is: For reland..