Show Overlay Scrollbar when GestureScrollUpdate

Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the 
WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
 show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2611013002
Cr-Commit-Position: refs/heads/master@{#456474}
Committed: https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3782c10513fab

[chaopeng, 2017-01-04 21:28:51]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually
changes position. In this patch, I also call the DidScrollUpdate when
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually
changes position. In this patch, I also call the DidScrollUpdate when
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-01-04 21:29:17]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually
changes position. In this patch, I also call the DidScrollUpdate when
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually
changes position. In this patch, I also call the DidScrollUpdate when
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-01-04 21:29:17]

chaopeng@chromium.org changed reviewers:
+ bokan@chromium.org

[chaopeng, 2017-01-04 21:29:29]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-01-04 21:30:05]

Please take a early look at this one.

[chaopeng, 2017-01-04 21:30:39]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually
changes position. In this patch, I also call the DidScrollUpdate when
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the DidScrollUpdate when 
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
==========

[commit-bot: I haz the power, 2017-01-04 22:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:13:36]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[bokan, 2017-01-05 13:44:25]

I think it'd be simpler to add a method on ScrollbarAnimationController like
willUpdateScroll() that sets opacity to 1. Call this from of LTHI::ScrollBy and
LTHI::ScrollAnimated before any early returns.

[chaopeng, 2017-01-05 21:56:43]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the DidScrollUpdate when 
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the DidScrollUpdate when 
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-01-05 21:59:03]

On 2017/01/05 13:44:25, bokan wrote:
> I think it'd be simpler to add a method on ScrollbarAnimationController like
> willUpdateScroll() that sets opacity to 1. Call this from of LTHI::ScrollBy
and
> LTHI::ScrollAnimated before any early returns.

bokan@, I added willUpdateScroll and didResize. Maybe we can remove
DidScrollUpdate. PTAL.

[chaopeng, 2017-02-24 21:24:45]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-02-24 21:24:52]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-02-24 21:28:03]

Patchset #3 (id:40001) has been deleted

[chaopeng, 2017-02-27 20:55:37]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 20:55:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-02-27 20:56:17]

Updated, PTAL. Thank you.

[commit-bot: I haz the power, 2017-02-27 22:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:19:48]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-02-27 23:34:17]

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:2766: // If no scroll happened during
a scroll gesture, it appears scrollbars and
I would leave this case as is and make sure no GSU means no effect. Add a test
below that checks that an empty ScrollBy queues an animation. Also, please add a
check for !ScrollbarsHidden

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:2907:
EXPECT_EQ(base::TimeDelta::FromMilliseconds(20),
Is this because the layer is already scrolled to the maximum offset so
previously it wouldn't have queued an animation?

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:251: scrollbar_needs_animation |=
clip_layer_size_did_change |=
Nit: separate this into separate lines.

[chaopeng, 2017-02-28 01:49:51]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 01:50:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-02-28 01:51:12]

Updated, PTAL. Thank you.

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:2907:
EXPECT_EQ(base::TimeDelta::FromMilliseconds(20),
On 2017/02/27 23:34:16, bokan wrote:
> Is this because the layer is already scrolled to the maximum offset so
> previously it wouldn't have queued an animation?

Yes,
https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_impl_unittest.c...

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:251: scrollbar_needs_animation |=
clip_layer_size_did_change |=
On 2017/02/27 23:34:17, bokan wrote:
> Nit: separate this into separate lines.

This is formatted by clang-format.

[commit-bot: I haz the power, 2017-02-28 03:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 03:03:55]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-02-28 14:16:08]

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2611013002/diff/60001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:251: scrollbar_needs_animation |=
clip_layer_size_did_change |=
On 2017/02/28 01:51:12, chaopeng wrote:
> On 2017/02/27 23:34:17, bokan wrote:
> > Nit: separate this into separate lines.
> 
> This is formatted by clang-format.

I mean separate statements. Turn it in to this:

clip_layer_size_did_change |= scrollbar->SetClipLayerLength(...);
scrollbar_needs_animation |= clip_layer_size_did_change;

https://codereview.chromium.org/2611013002/diff/80001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2611013002/diff/80001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:2775: // If no scroll happened during
a scroll gesture, it appears scrollbars and
nit: "appears" -> "fades in"

[chaopeng, 2017-02-28 14:31:52]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-02-28 14:32:10]

The CQ bit was unchecked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:32:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-02-28 14:33:11]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-02-28 14:33:24]

Patchset #5 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-02-28 14:33:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-02-28 14:33:27]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-02-28 14:33:43]

Updated, PTAL.

[bokan, 2017-02-28 14:42:27]

lgtm % comment

https://codereview.chromium.org/2611013002/diff/120001/cc/input/scrollbar_ani...
File cc/input/scrollbar_animation_controller.h (right):

https://codereview.chromium.org/2611013002/diff/120001/cc/input/scrollbar_ani...
cc/input/scrollbar_animation_controller.h:68: void WillUpdateScroll();
Please add a comment here that this expects to be called even if the scroll
position won't change as a result of the scroll.

[chaopeng, 2017-02-28 14:47:04]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-02-28 14:47:14]

The CQ bit was unchecked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:47:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-02-28 19:01:52]

chaopeng@chromium.org changed reviewers:
+ weiliangc@chromium.org

[chaopeng, 2017-02-28 19:01:53]

weiliangc@chromium.org: PTAL, Thank you.

[weiliangc, 2017-03-01 19:24:12]

LGTM % adding comment.

https://codereview.chromium.org/2611013002/diff/140001/cc/input/scrollbar_ani...
File cc/input/scrollbar_animation_controller.h (right):

https://codereview.chromium.org/2611013002/diff/140001/cc/input/scrollbar_ani...
cc/input/scrollbar_animation_controller.h:71: void DidResize();
Could you also comment on when DidResize is supposed to be called? (I'm assuming
whenever scroll bar or scroll area changed size?)

[chaopeng, 2017-03-01 19:44:12]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-03-01 19:44:23]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-03-02 15:39:55]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-03-02 15:39:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
weiliangc@chromium.org
Link to the patchset: https://codereview.chromium.org/2611013002/#ps160001
(title: "add comment to DidResize")

[commit-bot: I haz the power, 2017-03-02 15:40:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 15:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 15:42:32]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[chaopeng, 2017-03-02 16:12:54]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 16:13:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-03-02 16:13:16]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-03-02 16:15:34]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-03-02 16:15:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
weiliangc@chromium.org
Link to the patchset: https://codereview.chromium.org/2611013002/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-02 16:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 16:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 16:25:13]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chaopeng, 2017-03-02 16:58:41]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 16:59:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chaopeng, 2017-03-02 17:00:19]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-03-02 17:22:07]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the DidScrollUpdate when 
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the DidScrollUpdate when 
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-03-02 17:22:07]

chaopeng@chromium.org changed reviewers:
+ pdr@chromium.org

[chaopeng, 2017-03-02 17:23:26]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the DidScrollUpdate when 
GestureScrollUpdate so we can show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the 
WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
 show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chaopeng, 2017-03-02 17:28:48]

Patchset #8 (id:180001) has been deleted

[chaopeng, 2017-03-02 17:28:53]

Patchset #8 (id:200001) has been deleted

[chaopeng, 2017-03-02 17:32:22]

pdr: PTAL. I used CurrentlyScrollingLayer previously to find
ScrollbarAnimationController now I moved to
CurrentlyScrollingNode()::owning_layer_id.

[pdr., 2017-03-02 18:13:02]

On 2017/03/02 at 17:32:22, chaopeng wrote:
> pdr: PTAL. I used CurrentlyScrollingLayer previously to find
ScrollbarAnimationController now I moved to
CurrentlyScrollingNode()::owning_layer_id.

I'm in the middle of a large refactor to stop using owning_layer_id and instead
use either the scroll node's id or the scroll node's element_id
(https://crbug.com/693740). I was actually planning on moving
ScrollbarAnimationControllerForId to take an element_id today, but we don't need
to hold your patch up on that. Do you see any potential issues with your code
and using element_ids instead of layer ids? If not, LGTM for the use of
owning_layer_id.

[chaopeng, 2017-03-02 18:38:46]

On 2017/03/02 18:13:02, pdr. wrote:
> On 2017/03/02 at 17:32:22, chaopeng wrote:
> > pdr: PTAL. I used CurrentlyScrollingLayer previously to find
> ScrollbarAnimationController now I moved to
> CurrentlyScrollingNode()::owning_layer_id.
> 
> I'm in the middle of a large refactor to stop using owning_layer_id and
instead
> use either the scroll node's id or the scroll node's element_id
> (https://crbug.com/693740). I was actually planning on moving
> ScrollbarAnimationControllerForId to take an element_id today, but we don't
need
> to hold your patch up on that. Do you see any potential issues with your code
> and using element_ids instead of layer ids? If not, LGTM for the use of
> owning_layer_id.

Ok, Thank you. But I found a new issue related to property_tree.  would not land
it now.

[chaopeng, 2017-03-08 20:45:23]

Show Overlay Scrollbar when GestureScrollUpdate should only effect Aura Overlay
Scrollbar.

bokan@, weiliangc@ PTAL. Thank you.

[bokan, 2017-03-09 15:57:58]

Couple of nits but still lgtm once those are fixed.

https://codereview.chromium.org/2611013002/diff/240001/cc/input/scrollbar_ani...
File cc/input/scrollbar_animation_controller.cc (right):

https://codereview.chromium.org/2611013002/diff/240001/cc/input/scrollbar_ani...
cc/input/scrollbar_animation_controller.cc:221: if (need_thinning_animation_)
Instead of using need_thinning_animation_, add a bool
show_scrollbars_on_scroll_gesture_ and set it appropriately in the constructors.

https://codereview.chromium.org/2611013002/diff/240001/cc/input/scrollbar_ani...
File cc/input/scrollbar_animation_controller_unittest.cc (right):

https://codereview.chromium.org/2611013002/diff/240001/cc/input/scrollbar_ani...
cc/input/scrollbar_animation_controller_unittest.cc:1232: // Confirm the
scrollbar not appears by WillUpdateScroll on Android.
Nit: "scrollbar not appears by WillUpdateScroll" -> "scrollbar does not appear
on WillUpdateScroll"

https://codereview.chromium.org/2611013002/diff/240001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2611013002/diff/240001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_impl_unittest.cc:2849: // gesture, it appears
scrollbars and schedules a delay fade out.
nit: "it appears scrollbars and schedules" -> "show scrollbars and schedule"

https://codereview.chromium.org/2611013002/diff/240001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_impl_unittest.cc:2975: // For Aura Overlay Scrollbar,
scrollbar appears even scroll offset not
nit: "even scroll offset not change" -> "even if scroll offset didn't change"

[chaopeng, 2017-03-09 19:08:34]

weiliangc@ PTAL. Thank you.

[weiliangc, 2017-03-13 14:18:21]

LGTM.

[chaopeng, 2017-03-13 19:49:49]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-03-13 19:49:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2611013002/#ps260001
(title: "bokan comment#70 addressed")

[commit-bot: I haz the power, 2017-03-13 19:50:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 20:52:55]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1489434589561110,
"parent_rev": "e973fb670fcbdd7dc263f037d6d79fa31abb6553", "commit_rev":
"b2b25bd2d961354db5081b6090d3782c10513fab"}

[commit-bot: I haz the power, 2017-03-13 20:53:41]

Description was changed from

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the 
WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
 show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually 
changes position. In this patch, I also call the 
WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
 show scrollbar when we receive scroll gestures.

BUG=675594
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2611013002
Cr-Commit-Position: refs/heads/master@{#456474}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3...
==========

[commit-bot: I haz the power, 2017-03-13 20:53:43]

Committed patchset #10 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3...

[chaopeng, 2017-03-15 21:32:40]

A revert of this CL (patchset #10 id:260001) has been created in
https://codereview.chromium.org/2748343004/ by chaopeng@chromium.org.

The reason for reverting is: memory regression: crbug.com/701810.