Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: ios/web_view/public/criwv_translate_manager.h

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)
Patch Set: Apply review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/public/criwv_translate_manager.h
diff --git a/ios/web_view/public/criwv_translate_manager.h b/ios/web_view/public/criwv_translate_manager.h
index 8acd498d193673552025b4b8baec9b818e73b347..3202da4ba78b4ba49b927fa462fbb4aef5c30c37 100644
--- a/ios/web_view/public/criwv_translate_manager.h
+++ b/ios/web_view/public/criwv_translate_manager.h
@@ -7,8 +7,15 @@
#import <Foundation/Foundation.h>
+#if defined(CWV_IMPLEMENTATION)
Eugene But (OOO till 7-30) 2017/03/24 16:39:20 This is quite ugly for a public framework header.
Hiroshi Ichikawa 2017/03/27 02:09:25 This is currently necessary, even just to support
+#include "ios/web_view/public/cwv_export.h"
+#else
+#include <ChromeWebView/cwv_export.h>
+#endif
+
// Interface to manage the translation flow.
// Clients are not supposed to instantiate or subclass it.
+CWV_EXPORT
@protocol CRIWVTranslateManager<NSObject>
- (void)translate;

Powered by Google App Engine
This is Rietveld 408576698