Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web_view/shell/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)
Patch Set: Apply review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/web_view/public/criwv_translate_manager.h ('K') | « ios/web_view/public/cwv_web_view_configuration.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/shell/BUILD.gn
diff --git a/ios/web_view/shell/BUILD.gn b/ios/web_view/shell/BUILD.gn
index 14032cdfa5b560eecaa20d1a5fe801a05771abde..47746bd48a6af3c9eb27f447bc6a1bb29b0175ae 100644
--- a/ios/web_view/shell/BUILD.gn
+++ b/ios/web_view/shell/BUILD.gn
@@ -30,6 +30,13 @@ source_set("shell") {
"translate_controller.m",
]
+ # A workaround for an issue that we need to use the form:
michaeldo 2017/03/24 15:49:25 Please add crbug.com/704946 reference here.
Hiroshi Ichikawa 2017/03/27 02:09:25 Done.
+ # #include "ios/web_view/public/cwv_export.h"
+ # instead of:
+ # #include <ChromeWebView/cwv_export.h>
+ # when building this app.
+ defines = [ "CWV_IMPLEMENTATION" ]
+
deps = [
":resources",
"//ios/web_view",
« ios/web_view/public/criwv_translate_manager.h ('K') | « ios/web_view/public/cwv_web_view_configuration.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698