ios/web_view/internal/BUILD.gn - Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)

Patch Set: Apply review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/internal/BUILD.gn

diff --git a/ios/web_view/internal/BUILD.gn b/ios/web_view/internal/BUILD.gn

index 444aedad5d739b9c8db3248843b99e6a402ff6b1..cea2734647a1e22521dcd7f3f919e0985cd261a4 100644

--- a/ios/web_view/internal/BUILD.gn

+++ b/ios/web_view/internal/BUILD.gn

@@ -36,6 +36,11 @@ source_set("internal") {

"web_view_web_state_policy_decider.h",

"web_view_web_state_policy_decider.mm",

]

+ # Let header files know that it is building ios/web_view library, not using

+ # it.

+ defines = [ "CWV_IMPLEMENTATION" ]

Eugene But (OOO till 7-30) 2017/03/24 16:39:20 Is it possible to avoid duplicating CWV_IMPLEMENTA

Hiroshi Ichikawa 2017/03/27 02:09:25 What do you mean by duplicating? Dup between which

deps = [

"//base",

"//components/pref_registry",