Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2769263004: Remove Frame::host() method (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
slangley, haraken, dglazkov
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink, dtapuska+blinkwatch_chromium.org, haraken, kinuko+watch, mlamouri+watch-blink_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Frame::host() method Remove Frame::host() method and replace boolean checks (the only remaining calls) with Frame::page() which is an equivalent check. BUG=688614 Review-Url: https://codereview.chromium.org/2769263004 Cr-Commit-Position: refs/heads/master@{#460016} Committed: https://chromium.googlesource.com/chromium/src/+/6badfa25e06f54413e408cd6d14427a7f44356a1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M third_party/WebKit/Source/core/frame/DOMWindow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
sashab
https://codereview.chromium.org/2769263004/diff/1/third_party/WebKit/Source/core/frame/RemoteFrame.cpp File third_party/WebKit/Source/core/frame/RemoteFrame.cpp (right): https://codereview.chromium.org/2769263004/diff/1/third_party/WebKit/Source/core/frame/RemoteFrame.cpp#newcode111 third_party/WebKit/Source/core/frame/RemoteFrame.cpp:111: return !!page(); Replacing this with page() != nullptr gives ...
3 years, 9 months ago (2017-03-24 00:33:06 UTC) #2
haraken
LGTM https://codereview.chromium.org/2769263004/diff/1/third_party/WebKit/Source/core/frame/RemoteFrame.cpp File third_party/WebKit/Source/core/frame/RemoteFrame.cpp (right): https://codereview.chromium.org/2769263004/diff/1/third_party/WebKit/Source/core/frame/RemoteFrame.cpp#newcode111 third_party/WebKit/Source/core/frame/RemoteFrame.cpp:111: return !!page(); On 2017/03/24 00:33:05, sashab wrote: > ...
3 years, 9 months ago (2017-03-24 00:36:49 UTC) #6
dglazkov
lgtm
3 years, 8 months ago (2017-03-27 20:15:54 UTC) #10
slangley
lgtm
3 years, 8 months ago (2017-03-27 23:04:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769263004/1
3 years, 8 months ago (2017-03-28 02:58:38 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 04:59:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6badfa25e06f54413e408cd6d144...

Powered by Google App Engine
This is Rietveld 408576698