Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 2769263004: Remove Frame::host() method (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
index e864435226d862991a9816cad4617f57d8fc1615..7173101a816f7630f88ce5fe5ee20398d462f853 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
@@ -108,7 +108,7 @@ void RemoteFrame::detach(FrameDetachType type) {
bool RemoteFrame::prepareForCommit() {
detachChildren();
- return !!host();
+ return !!page();
sashab 2017/03/24 00:33:05 Replacing this with page() != nullptr gives the er
haraken 2017/03/24 00:36:49 Yes, it's a common pattern.
}
RemoteSecurityContext* RemoteFrame::securityContext() const {
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameConsole.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698