Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2769263004: Remove Frame::host() method (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 4108 matching lines...) Expand 10 before | Expand all | Expand 10 after
4119 webView->setOpenedByDOM(); 4119 webView->setOpenedByDOM();
4120 4120
4121 LocalFrame* mainFrame = toLocalFrame(page->mainFrame()); 4121 LocalFrame* mainFrame = toLocalFrame(page->mainFrame());
4122 EXPECT_FALSE(mainFrame->domWindow()->closed()); 4122 EXPECT_FALSE(mainFrame->domWindow()->closed());
4123 4123
4124 mainFrame->domWindow()->close(nullptr); 4124 mainFrame->domWindow()->close(nullptr);
4125 // The window should be marked closed... 4125 // The window should be marked closed...
4126 EXPECT_TRUE(mainFrame->domWindow()->closed()); 4126 EXPECT_TRUE(mainFrame->domWindow()->closed());
4127 // EXPECT_TRUE(page->isClosing()); 4127 // EXPECT_TRUE(page->isClosing());
4128 // ...but not yet detached. 4128 // ...but not yet detached.
4129 EXPECT_TRUE(mainFrame->host()); 4129 EXPECT_TRUE(mainFrame->page());
4130 4130
4131 { 4131 {
4132 ScopedPageSuspender suspender; 4132 ScopedPageSuspender suspender;
4133 EXPECT_TRUE(page->suspended()); 4133 EXPECT_TRUE(page->suspended());
4134 } 4134 }
4135 } 4135 }
4136 4136
4137 TEST_P(WebViewTest, ForceAndResetViewport) { 4137 TEST_P(WebViewTest, ForceAndResetViewport) {
4138 registerMockedHttpURLLoad("200-by-300.html"); 4138 registerMockedHttpURLLoad("200-by-300.html");
4139 WebViewImpl* webViewImpl = 4139 WebViewImpl* webViewImpl =
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
4428 EXPECT_FALSE(frameView->visualViewportSuppliesScrollbars()); 4428 EXPECT_FALSE(frameView->visualViewportSuppliesScrollbars());
4429 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) { 4429 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
4430 EXPECT_NE(nullptr, 4430 EXPECT_NE(nullptr,
4431 frameView->layoutViewportScrollableArea()->verticalScrollbar()); 4431 frameView->layoutViewportScrollableArea()->verticalScrollbar());
4432 } else { 4432 } else {
4433 EXPECT_NE(nullptr, frameView->verticalScrollbar()); 4433 EXPECT_NE(nullptr, frameView->verticalScrollbar());
4434 } 4434 }
4435 } 4435 }
4436 4436
4437 } // namespace blink 4437 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698