Remove Frame::host() method

third_party/WebKit/Source/core/frame/RemoteFrame.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/RemoteFrame.h"
 
 #include "bindings/core/v8/WindowProxy.h"
 #include "bindings/core/v8/WindowProxyManager.h"
 #include "core/dom/RemoteSecurityContext.h"
 #include "core/frame/FrameHost.h"
@@ skipping 90 matching lines @@
   // persistent strong references to RemoteDOMWindow will prevent the GCing
   // of all these objects. Break the cycle by notifying of detachment.
   toRemoteDOMWindow(m_domWindow)->frameDetached();
   if (m_webLayer)
     setWebLayer(nullptr);
   Frame::detach(type);
 }
 
 bool RemoteFrame::prepareForCommit() {
   detachChildren();
-  return !!host();
+  return !!page();

[sashab, 2017/03/24 00:33:05]

Replacing this with page() != nullptr gives the error:

third_party/WebKit/Source/core/frame/RemoteFrame.cpp:111:  Tests for true/false
and null/non-null should be done without equality comparisons. 
[readability/comparison_to_boolean] [5]

I can't find this in the style guide :/ is this !! pattern the "normal" way to
convert to bool?

[haraken, 2017/03/24 00:36:49]

Yes, it's a common pattern.

 }
 
 RemoteSecurityContext* RemoteFrame::securityContext() const {
   return m_securityContext.get();
 }
 
 bool RemoteFrame::shouldClose() {
   // TODO(nasko): Implement running the beforeunload handler in the actual
   // LocalFrame running in a different process and getting back a real result.
   return true;
@@ skipping 47 matching lines @@
   FrameVector childrenToDetach;
   childrenToDetach.reserveCapacity(tree().childCount());
   for (Frame* child = tree().firstChild(); child;
        child = child->tree().nextSibling())
     childrenToDetach.push_back(child);
   for (const auto& child : childrenToDetach)
     child->detach(FrameDetachType::Remove);
 }
 
 }  // namespace blink