Initial work to move downloads to ContentIds

Initial work to move downloads to ContentIds

Right now the DownloadNotificationService identifies downloads by a
GUID and a boolean, which lets it both uniquely identify that item and
associate it with an underlying provider (download or offline page).
We're moving all downloaded content to be identified by a ContentId and
represented as an OfflineItem.  As part of that work (based on need
priority) we're moving the DownloadNotificationService to use ContentIds
instead of a GUID and boolean.

Migration details:
1. Downloads will be given the namespace LEGACY_DOWNLOADS until they are
migrated.
2. Offline pages will be given the namespace LEGACY_OFFLINE_PAGES until
they are migrated.
3. The backend provider will be determined by the ContentId based on the
legacy constants mentioned above.

BUG=691805
Review-Url: https://codereview.chromium.org/2768953002
Cr-Commit-Position: refs/heads/master@{#460319}
Committed: https://chromium.googlesource.com/chromium/src/+/8b97a74f58c8b45a85de5c5521a58a54a0935700

[David Trainor- moved to gerrit, 2017-03-22 21:35:29]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[David Trainor- moved to gerrit, 2017-03-22 21:36:00]

https://codereview.chromium.org/2768953002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://codereview.chromium.org/2768953002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:60:
mContentId.id = getId();
TODO(me): Is this right?

https://codereview.chromium.org/2768953002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(left):

https://codereview.chromium.org/2768953002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:76:
static final String EXTRA_IS_OFFLINE_PAGE =
Do we need to maintain these to build the ContentId from old Intents?

[commit-bot: I haz the power, 2017-03-22 21:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-03-22 21:37:26]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 21:37:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:03:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:03:26]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[David Trainor- moved to gerrit, 2017-03-23 00:05:14]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:06:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:43:51]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[David Trainor- moved to gerrit, 2017-03-23 01:12:37]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 01:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:47:04]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[David Trainor- moved to gerrit, 2017-03-23 02:23:08]

dtrainor@chromium.org changed reviewers:
+ dfalcantara@chromium.org, fgorski@chromium.org, qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-03-23 02:23:09]

Hey all!  This patch attempts to migrate the DownloadNotificationService to use
ContentIds for all download tracking.  Just wanted to give you a heads up about
this.

As an FYI, I still need to do more comprehensive testing to validate all of it. 
I did validate that downloads and offline pages work as expected, but I need to
check more edge cases.

Thanks!

[gone, 2017-03-24 01:52:17]

lgtm

I know you said you have some corrections to this CL, but for the life of me I
can't see where they'd go.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:57:
* @return A {@link ContentId} that represents this downloaded item.  The ID will
match the id
ID id Id

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:61:
mContentId.id = getId();
Does this imply mContentId can be out of date?  Do you picture trying to access
mContentId from anywhere except getContentId()?

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:73:
"org.chromium.chrome.browser.download.DownloadContentIdId";
I know this string isn't wrong, but it looks that way way.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:90:
if (version > 2 && version < 5) {
maybe == 3 || == 4?  this looked wrong when I saw 5.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:111:
if (version > 3) isAutoResumable = "1".equals(values[currentIndex++]);
I'd seriously consider using >= instead of > in general to make it more obvious
what version things apply to.

[fgorski, 2017-03-24 16:49:32]

mostly looks good, but think about the version upgrade.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:66:
if (version <= 0 || version > 4) return INVALID_ENTRY;
V 5 deemed invalid? ;)

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:79:
// "VERSION, NOTIFICATIONID, OFFTHERECORD, METEREDOK, AUTORESUMEOK, ID,
FILENAME, NAMESPACE"
I know this probably simplifies the code... or not, but, given the change we are
making, why now:
a) group the things that are related together: ID, NAMESPACE
b) Leave the current method for loading old versions almost as is (with stuff
necessary for update to current.
c) have a separate method that can load version 5.

We use b), c) all the time in SQL code, when we change db schema. Typically we
call methods something like:
UpgradeFromM54  and it knows how to detect that version and apply changes to
make DB current. This is very similar.
I think it will be cleaner.

Another thing that could be done is split of this method in 4:
UpgradeFromVersion1:
UpgradeFromVersion2:...
Each one detailing the format as you did above, as I think that is pretty good.
I know we will lose some of the overlapping upgrade, and there will be more
code, but think about how testable that thing is... and every method keeps the
same input, while you expect the current format as an output.

This can be done as a separate patch and if you want me to do it, I will.

https://codereview.chromium.org/2768953002/diff/80001/components/offline_item...
File
components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/LegacyHelpers.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/components/offline_item...
components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/LegacyHelpers.java:13:
public static final String LEGACY_DOWNLOAD_NAMESPACE = "LEGACY_DOWNLOAD";
Can we mention that these are legacy namespace for purpose of ID generation on
only affect the UI?

[qinmin, 2017-03-24 21:17:25]

lgtm % comment

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:72:
} else if (version == 4 || version == 5) {
new test for v4->v5 conversion?

[David Trainor- moved to gerrit, 2017-03-24 22:12:01]

ptal thanks!

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:57:
* @return A {@link ContentId} that represents this downloaded item.  The ID will
match the id
On 2017/03/24 01:52:17, dfalcantara (load balance plz) wrote:
> ID id Id

Done.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:61:
mContentId.id = getId();
On 2017/03/24 01:52:17, dfalcantara (load balance plz) wrote:
> Does this imply mContentId can be out of date?  Do you picture trying to
access
> mContentId from anywhere except getContentId()?

I can make this a bit more robust.  Will update mContentId when the system id
changes.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:73:
"org.chromium.chrome.browser.download.DownloadContentIdId";
On 2017/03/24 01:52:17, dfalcantara (load balance plz) wrote:
> I know this string isn't wrong, but it looks that way way.

Added an _.  lmk if that's better :).

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:66:
if (version <= 0 || version > 4) return INVALID_ENTRY;
On 2017/03/24 16:49:32, fgorski wrote:
> V 5 deemed invalid? ;)

Yes!  Just saw this when I was getting the junit tests working.  Welp that
explains why restarts were not working as expected :D.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:72:
} else if (version == 4 || version == 5) {
On 2017/03/24 21:17:25, qinmin wrote:
> new test for v4->v5 conversion?

Thanks!  Yeah I hadn't added tests for this yet.  My bad.  Added now and
reworked a lot of this logic to reduce the branching.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:79:
// "VERSION, NOTIFICATIONID, OFFTHERECORD, METEREDOK, AUTORESUMEOK, ID,
FILENAME, NAMESPACE"
On 2017/03/24 16:49:32, fgorski wrote:
> I know this probably simplifies the code... or not, but, given the change we
are
> making, why now:
> a) group the things that are related together: ID, NAMESPACE
> b) Leave the current method for loading old versions almost as is (with stuff
> necessary for update to current.
> c) have a separate method that can load version 5.
> 
> We use b), c) all the time in SQL code, when we change db schema. Typically we
> call methods something like:
> UpgradeFromM54  and it knows how to detect that version and apply changes to
> make DB current. This is very similar.
> I think it will be cleaner.
> 
> Another thing that could be done is split of this method in 4:
> UpgradeFromVersion1:
> UpgradeFromVersion2:...
> Each one detailing the format as you did above, as I think that is pretty
good.
> I know we will lose some of the overlapping upgrade, and there will be more
> code, but think about how testable that thing is... and every method keeps the
> same input, while you expect the current format as an output.
> 
> This can be done as a separate patch and if you want me to do it, I will.

Yeah I think LoadFromVersion1(), LoadFromVersion2(), etc. would be fine as well.
 That would split out the read code for each version into a single component.  I
think we don't necessarily need an upgrade step for all of these entries at
startup because there is no actual 'schema' on disk we need to update, updates
always just work.  But I really like the separate load idea.  Will flesh out.

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:90:
if (version > 2 && version < 5) {
On 2017/03/24 01:52:17, dfalcantara (load balance plz) wrote:
> maybe == 3 || == 4?  this looked wrong when I saw 5.

Will do!

https://codereview.chromium.org/2768953002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:111:
if (version > 3) isAutoResumable = "1".equals(values[currentIndex++]);
On 2017/03/24 01:52:17, dfalcantara (load balance plz) wrote:
> I'd seriously consider using >= instead of > in general to make it more
obvious
> what version things apply to.

Acknowledged.

https://codereview.chromium.org/2768953002/diff/80001/components/offline_item...
File
components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/LegacyHelpers.java
(right):

https://codereview.chromium.org/2768953002/diff/80001/components/offline_item...
components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/LegacyHelpers.java:13:
public static final String LEGACY_DOWNLOAD_NAMESPACE = "LEGACY_DOWNLOAD";
On 2017/03/24 16:49:32, fgorski wrote:
> Can we mention that these are legacy namespace for purpose of ID generation on
> only affect the UI?

Done.

[David Trainor- moved to gerrit, 2017-03-28 03:28:16]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 03:28:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 04:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:38:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Trainor- moved to gerrit, 2017-03-28 16:39:57]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 16:41:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:19:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2017-03-28 17:57:11]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 17:57:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 18:01:02]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[David Trainor- moved to gerrit, 2017-03-28 18:39:41]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 18:40:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:28:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2017-03-28 22:25:49]

lgtm. Thanks for breaking down the preference version parsing.

[David Trainor- moved to gerrit, 2017-03-28 22:37:28]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-03-28 22:37:29]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2768953002/#ps160001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-28 22:37:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 23:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:24:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Trainor- moved to gerrit, 2017-03-28 23:29:31]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-03-28 23:29:32]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dfalcantara@chromium.org, fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2768953002/#ps180001
(title: "Rebased again")

[commit-bot: I haz the power, 2017-03-28 23:30:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:12:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2017-03-29 04:17:08]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2017-03-29 04:17:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 05:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 05:39:34]

Failed to apply patch for
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java:23
  Falling back to three-way merge...
  Applied patch to
'chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java'
with conflicts.
  U
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Patch:      
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
Index:
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
diff --git
a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
index
bc487aa4ae4ad6fb8e8113f9151922fe24caa661..71c3fa29b54a7c88eeffa97263ec5e4851df40eb
100644
---
a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
+++
b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
@@ -23,6 +23,7 @@ import org.chromium.base.test.util.RetryOnFailure;
 import org.chromium.base.test.util.UrlUtils;
 import org.chromium.chrome.browser.download.DownloadInfo.Builder;
 import
org.chromium.chrome.browser.download.DownloadManagerServiceTest.MockDownloadNotifier.MethodID;
+import org.chromium.components.offline_items_collection.ContentId;
 import org.chromium.content.browser.test.NativeLibraryTestBase;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
@@ -303,7 +304,7 @@ public class DownloadManagerServiceTest extends
NativeLibraryTestBase {
         protected void init() {}
 
         @Override
-        public void resumeDownload(DownloadItem item, boolean hasUserGesture) {
+        public void resumeDownload(ContentId id, DownloadItem item, boolean
hasUserGesture) {
             mResumed = true;
         }

[David Trainor- moved to gerrit, 2017-03-29 05:48:43]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-03-29 05:48:43]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dfalcantara@chromium.org, fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2768953002/#ps200001
(title: "Rebase because of a conflict... with a single. import. :(")

[commit-bot: I haz the power, 2017-03-29 05:49:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 07:39:10]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1490766523143320,
"parent_rev": "d9eef669c7b792da254dbb6dc71a0b770bc7201f", "commit_rev":
"8b97a74f58c8b45a85de5c5521a58a54a0935700"}

[commit-bot: I haz the power, 2017-03-29 07:39:54]

Description was changed from

==========
Initial work to move downloads to ContentIds

Right now the DownloadNotificationService identifies downloads by a
GUID and a boolean, which lets it both uniquely identify that item and
associate it with an underlying provider (download or offline page).
We're moving all downloaded content to be identified by a ContentId and
represented as an OfflineItem.  As part of that work (based on need
priority) we're moving the DownloadNotificationService to use ContentIds
instead of a GUID and boolean.

Migration details:
1. Downloads will be given the namespace LEGACY_DOWNLOADS until they are
migrated.
2. Offline pages will be given the namespace LEGACY_OFFLINE_PAGES until
they are migrated.
3. The backend provider will be determined by the ContentId based on the
legacy constants mentioned above.

BUG=691805
==========

to

==========
Initial work to move downloads to ContentIds

Right now the DownloadNotificationService identifies downloads by a
GUID and a boolean, which lets it both uniquely identify that item and
associate it with an underlying provider (download or offline page).
We're moving all downloaded content to be identified by a ContentId and
represented as an OfflineItem.  As part of that work (based on need
priority) we're moving the DownloadNotificationService to use ContentIds
instead of a GUID and boolean.

Migration details:
1. Downloads will be given the namespace LEGACY_DOWNLOADS until they are
migrated.
2. Offline pages will be given the namespace LEGACY_OFFLINE_PAGES until
they are migrated.
3. The backend provider will be determined by the ContentId based on the
legacy constants mentioned above.

BUG=691805

Review-Url: https://codereview.chromium.org/2768953002
Cr-Commit-Position: refs/heads/master@{#460319}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b97a74f58c8b45a85de5c5521a5...
==========

[commit-bot: I haz the power, 2017-03-29 07:39:56]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/8b97a74f58c8b45a85de5c5521a5...