Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: components/offline_items_collection/core/offline_item.h

Issue 2768953002: Initial work to move downloads to ContentIds (Closed)
Patch Set: Rebase because of a conflict... with a single. import. :( Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_items_collection/core/offline_item.h
diff --git a/components/offline_items_collection/core/offline_item.h b/components/offline_items_collection/core/offline_item.h
index 835311190fb155de2ca17eaa120335623808aa95..a06e8c7d6537f6af115519d64eea946d90132bfe 100644
--- a/components/offline_items_collection/core/offline_item.h
+++ b/components/offline_items_collection/core/offline_item.h
@@ -17,7 +17,10 @@ namespace offline_items_collection {
// An id that uniquely represents a piece of offline content.
struct ContentId {
// The namespace for the offline content. This will be used to associate this
- // id with a particular OfflineContentProvider.
+ // id with a particular OfflineContentProvider. A name_space can include
+ // any characters except ','. This is due to a serialization format
+ // limitation.
+ // TODO(dtrainor): Remove the 'no ,' limitation.
std::string name_space;
// The id of the offline item.

Powered by Google App Engine
This is Rietveld 408576698