Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3835)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

Issue 2768953002: Initial work to move downloads to ContentIds (Closed)
Patch Set: Rebase because of a conflict... with a single. import. :( Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java
index 27a518c27259c3c3c78a3b39a34712aa7ca94555..40202e1c1a6b5663d885fba8c0a56675be2d339b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java
@@ -4,29 +4,32 @@
package org.chromium.chrome.browser.download;
+import org.chromium.components.offline_items_collection.ContentId;
+
/** Interface for classes implementing concrete implementation of UI behavior. */
public interface DownloadServiceDelegate {
/**
* Called to cancel a download.
- * @param downloadGuid GUID of the download.
+ * @param id The {@link ContentId} of the download to cancel.
* @param isOffTheRecord Whether the download is off the record.
*/
- void cancelDownload(String downloadGuid, boolean isOffTheRecord);
+ void cancelDownload(ContentId id, boolean isOffTheRecord);
/**
* Called to pause a download.
- * @param downloadGuid GUID of the download.
+ * @param id The {@link ContentId} of the download to pause.
* @param isOffTheRecord Whether the download is off the record.
*/
- void pauseDownload(String downloadGuid, boolean isOffTheRecord);
+ void pauseDownload(ContentId id, boolean isOffTheRecord);
/**
* Called to resume a paused download.
+ * @param id The {@link ContentId} of the download to cancel.
* @param item Download item to resume.
* @param hasUserGesture Whether the resumption is triggered by user gesture.
* TODO(fgorski): Update the interface to not require download item.
*/
- void resumeDownload(DownloadItem item, boolean hasUserGesture);
+ void resumeDownload(ContentId id, DownloadItem item, boolean hasUserGesture);
/** Called to destroy the delegate, in case it needs to be destroyed. */
void destroyServiceDelegate();

Powered by Google App Engine
This is Rietveld 408576698