chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java - Issue 2768953002: Initial work to move downloads to ContentIds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Issue 2768953002: Initial work to move downloads to ContentIds (Closed)

Patch Set: Rebase because of a conflict... with a single. import. :( Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

index 9ec0c0b076e4eaea4a8d117198cd54a11b9a91dc..ec03a48e546d16a54a525a355a162c36525b8fcc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

@@ -26,6 +26,7 @@ import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBri

import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadItem;

import org.chromium.chrome.browser.widget.DateDividedAdapter;

import org.chromium.chrome.browser.widget.selection.SelectionDelegate;

+import org.chromium.components.offline_items_collection.ContentId;

import org.chromium.content_public.browser.DownloadState;

import java.util.ArrayList;

@@ -422,10 +423,10 @@ public class DownloadHistoryAdapter extends DateDividedAdapter

}

@Override

- public void onAddOrReplaceDownloadSharedPreferenceEntry(final String guid) {

+ public void onAddOrReplaceDownloadSharedPreferenceEntry(final ContentId id) {

// Alert DownloadItemViews displaying information about the item that it has changed.

for (DownloadItemView view : mViews) {

- if (TextUtils.equals(guid, view.getItem().getId())) {

+ if (TextUtils.equals(id.id, view.getItem().getId())) {

view.displayItem(mBackendProvider, view.getItem());

}