Use CollectionViewTextItem instead of a cast

Use CollectionViewTextItem instead of a cast

To set the color and the font of the cell handled by a CollectionViewTextItem,
some classes where selecting the cell and casting it to a
CollectionViewTextCell.
This CL sets the style directly in the item.

BUG=704082
Review-Url: https://codereview.chromium.org/2768933005
Cr-Commit-Position: refs/heads/master@{#459378}
Committed: https://chromium.googlesource.com/chromium/src/+/0b9612c36b6ba03e3f007114bff6347295c7d427

[gambard, 2017-03-24 08:44:07]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-03-24 08:44:08]

PTAL.

[gambard, 2017-03-24 08:52:40]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 08:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:00:12]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[gambard, 2017-03-24 09:04:41]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:04:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:11:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[lpromero, 2017-03-24 09:24:42]

Description was changed from

==========
Use CollectionViewTextItem instead of a cast

To set the color and the font of the cell handled by a CollectionViewTextItem,
some classes where selecting the cell and casting it to a
CollectionViewCellItem.
This CL set the style directly in the item.

BUG=704082
==========

to

==========
Use CollectionViewTextItem instead of a cast

To set the color and the font of the cell handled by a CollectionViewTextItem,
some classes where selecting the cell and casting it to a
CollectionViewTextCell.
This CL sets the style directly in the item.

BUG=704082
==========

[lpromero, 2017-03-24 09:28:24]

Thanks for doing that! It's a nice cleanup.

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
(right):

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm:115:
[[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
MDCTypography got updated recently to have medium fonts too. Can you look if you
can migrate to it?

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
(right):

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/translate_collection_view_controller.mm:111:
[[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
Idem for Roboto→Typography.

[lpromero, 2017-03-24 09:28:26]

lgtm

Thanks for doing that! It's a nice cleanup.

[gambard, 2017-03-24 09:49:03]

Thanks!

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
(right):

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm:115:
[[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
On 2017/03/24 09:28:24, lpromero wrote:
> MDCTypography got updated recently to have medium fonts too. Can you look if
you
> can migrate to it?

Done.

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
(right):

https://codereview.chromium.org/2768933005/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/translate_collection_view_controller.mm:111:
[[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
On 2017/03/24 09:28:24, lpromero wrote:
> Idem for Roboto→Typography.

Done.

[gambard, 2017-03-24 09:49:07]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-24 09:49:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2768933005/#ps40001
(title: "Remove MDFRoboto")

[commit-bot: I haz the power, 2017-03-24 09:49:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:59:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490348947518170,
"parent_rev": "8e52305016cd7750c6d168e9d995345928de3c02", "commit_rev":
"0b9612c36b6ba03e3f007114bff6347295c7d427"}

[commit-bot: I haz the power, 2017-03-24 10:00:29]

Description was changed from

==========
Use CollectionViewTextItem instead of a cast

To set the color and the font of the cell handled by a CollectionViewTextItem,
some classes where selecting the cell and casting it to a
CollectionViewTextCell.
This CL sets the style directly in the item.

BUG=704082
==========

to

==========
Use CollectionViewTextItem instead of a cast

To set the color and the font of the cell handled by a CollectionViewTextItem,
some classes where selecting the cell and casting it to a
CollectionViewTextCell.
This CL sets the style directly in the item.

BUG=704082

Review-Url: https://codereview.chromium.org/2768933005
Cr-Commit-Position: refs/heads/master@{#459378}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b9612c36b6ba03e3f007114bff6...
==========

[commit-bot: I haz the power, 2017-03-24 10:00:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0b9612c36b6ba03e3f007114bff6...