Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

Issue 2768933005: Use CollectionViewTextItem instead of a cast (Closed)
Patch Set: Remove MDFRoboto Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm b/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
index 2da625e3a3e43e2c77272942f0fe17e9e08af736..9cd65b8796d536527ba2b794a8d9811420085bda 100644
--- a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
@@ -123,6 +123,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule
[[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease];
usernameHeader.text =
l10n_util::GetNSString(IDS_IOS_SHOW_PASSWORD_VIEW_USERNAME);
+ usernameHeader.textColor = [[MDCPalette greyPalette] tint500];
[model setHeader:usernameHeader
forSectionWithIdentifier:SectionIdentifierUsername];
PasswordDetailsItem* usernameItem =
@@ -137,6 +138,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule
[[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease];
passwordHeader.text =
l10n_util::GetNSString(IDS_IOS_SHOW_PASSWORD_VIEW_PASSWORD);
+ passwordHeader.textColor = [[MDCPalette greyPalette] tint500];
[model setHeader:passwordHeader
forSectionWithIdentifier:SectionIdentifierPassword];
_passwordItem.reset(
@@ -183,6 +185,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule
CollectionViewTextItem* item = [
[[CollectionViewTextItem alloc] initWithType:ItemTypeDelete] autorelease];
item.text = l10n_util::GetNSString(IDS_IOS_SETTINGS_PASSWORD_DELETE_BUTTON);
+ item.textColor = [[MDCPalette cr_redPalette] tint500];
item.accessibilityTraits |= UIAccessibilityTraitButton;
return item;
}
@@ -300,37 +303,6 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule
[_weakDelegate deletePassword:_passwordForm];
}
-#pragma mark - UICollectionViewDataSource
-
-- (UICollectionReusableView*)collectionView:(UICollectionView*)collectionView
- viewForSupplementaryElementOfKind:(NSString*)kind
- atIndexPath:(NSIndexPath*)indexPath {
- UICollectionReusableView* view = [super collectionView:collectionView
- viewForSupplementaryElementOfKind:kind
- atIndexPath:indexPath];
- MDCCollectionViewTextCell* textCell =
- base::mac::ObjCCast<MDCCollectionViewTextCell>(view);
- if (textCell) {
- textCell.textLabel.textColor = [[MDCPalette greyPalette] tint500];
- }
- return view;
-}
-
-- (UICollectionViewCell*)collectionView:(UICollectionView*)collectionView
- cellForItemAtIndexPath:(NSIndexPath*)indexPath {
- UICollectionViewCell* cell =
- [super collectionView:collectionView cellForItemAtIndexPath:indexPath];
-
- NSInteger type = [self.collectionViewModel itemTypeForIndexPath:indexPath];
- if (type == ItemTypeDelete) {
- MDCCollectionViewTextCell* textCell =
- base::mac::ObjCCastStrict<MDCCollectionViewTextCell>(cell);
- textCell.textLabel.textColor = [[MDCPalette cr_redPalette] tint500];
- }
-
- return cell;
-}
-
#pragma mark - UICollectionViewDelegate
- (void)collectionView:(UICollectionView*)collectionView

Powered by Google App Engine
This is Rietveld 408576698