Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

Issue 2768933005: Use CollectionViewTextItem instead of a cast (Closed)
Patch Set: Remove MDFRoboto Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm b/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
index 03f465655cbc43856f80ab1b8191754486e7be57..db548f635bed35228e6876b996dfba87d017434c 100644
--- a/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
@@ -146,20 +146,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
return cell;
}
-- (UICollectionReusableView*)collectionView:(UICollectionView*)collectionView
- viewForSupplementaryElementOfKind:(NSString*)kind
- atIndexPath:(NSIndexPath*)indexPath {
- UICollectionReusableView* view = [super collectionView:collectionView
- viewForSupplementaryElementOfKind:kind
- atIndexPath:indexPath];
- MDCCollectionViewTextCell* textCell =
- base::mac::ObjCCast<MDCCollectionViewTextCell>(view);
- if (textCell) {
- textCell.textLabel.textColor = [[MDCPalette greyPalette] tint500];
- }
- return view;
-};
-
#pragma mark - MDCCollectionViewEditingDelegate
- (BOOL)collectionView:(UICollectionView*)collectionView
@@ -311,6 +297,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
CollectionViewTextItem* header = [
[[CollectionViewTextItem alloc] initWithType:ItemTypeHeader] autorelease];
header.text = l10n_util::GetNSString(IDS_IOS_POPUPS_ALLOWED);
+ header.textColor = [[MDCPalette greyPalette] tint500];
[model setHeader:header forSectionWithIdentifier:SectionIdentifierExceptions];
for (size_t i = 0; i < _exceptions.GetSize(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698