ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm - Issue 2768933005: Use CollectionViewTextItem instead of a cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

Issue 2768933005: Use CollectionViewTextItem instead of a cast (Closed)

Patch Set: Remove MDFRoboto Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm b/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

index 4143e7da59ad5ce75adcd901590184d09746ed99..5e65e4fc9e00944191e55f6b7b41951bfa51065f 100644

--- a/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

@@ -332,6 +332,7 @@ const int kMaxTimesHistoryNoticeShown = 1;

initWithType:ItemTypeClearBrowsingDataButton] autorelease];

clearButtonItem.text = l10n_util::GetNSString(IDS_IOS_CLEAR_BUTTON);

clearButtonItem.accessibilityTraits |= UIAccessibilityTraitButton;

+ clearButtonItem.textColor = [[MDCPalette cr_redPalette] tint500];

[model addItem:clearButtonItem

toSectionWithIdentifier:SectionIdentifierClearBrowsingDataButton];

@@ -498,23 +499,6 @@ const int kMaxTimesHistoryNoticeShown = 1;

return timeRangeItem;

}

-#pragma mark UICollectionViewDataSource

-- (UICollectionViewCell*)collectionView:(UICollectionView*)collectionView

- cellForItemAtIndexPath:(NSIndexPath*)indexPath {

- UICollectionViewCell* cell =

- [super collectionView:collectionView cellForItemAtIndexPath:indexPath];

- NSInteger type = [self.collectionViewModel itemTypeForIndexPath:indexPath];

- if (type == ItemTypeClearBrowsingDataButton) {

- MDCCollectionViewTextCell* textCell =

- base::mac::ObjCCastStrict<MDCCollectionViewTextCell>(cell);

- textCell.textLabel.textColor = [[MDCPalette cr_redPalette] tint500];

- }

- return cell;

#pragma mark UICollectionViewDelegate

- (void)collectionView:(UICollectionView*)collectionView