Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2767343004: Return const references in the Blink SW API where possible (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, kinuko+watch, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return const references in the Blink SW API where possible BUG= Review-Url: https://codereview.chromium.org/2767343004 Cr-Commit-Position: refs/heads/master@{#459739} Committed: https://chromium.googlesource.com/chromium/src/+/f644d8ec735b8602295d045fddfdc43ad654b3cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Peter Beverloo
+kinuko
3 years, 9 months ago (2017-03-24 17:55:04 UTC) #3
kinuko
lgtm
3 years, 9 months ago (2017-03-27 05:56:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767343004/1
3 years, 9 months ago (2017-03-27 05:57:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/336281)
3 years, 9 months ago (2017-03-27 08:40:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767343004/1
3 years, 9 months ago (2017-03-27 09:20:55 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 10:11:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f644d8ec735b8602295d045fddfd...

Powered by Google App Engine
This is Rietveld 408576698