Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h

Issue 2767343004: Return const references in the Blink SW API where possible (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
index 3c1d0d7fe869e715e0da064f1276bb50cea4b7b9..e685b9b932ab01e5e7140aa8cf46d61b3b3cd09c 100644
--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
@@ -13,11 +13,11 @@
#include "public/platform/WebURLRequest.h"
#if INSIDE_BLINK
+#include <utility>
#include "platform/network/HTTPHeaderMap.h"
#include "platform/weborigin/Referrer.h"
#include "wtf/Forward.h"
#include "wtf/text/StringHash.h"
-#include <utility>
#endif
namespace blink {
@@ -43,10 +43,10 @@ class BLINK_PLATFORM_EXPORT WebServiceWorkerRequest {
void assign(const WebServiceWorkerRequest&);
void setURL(const WebURL&);
- WebURL url() const;
+ const WebURL& url() const;
void setMethod(const WebString&);
- WebString method() const;
+ const WebString& method() const;
void setHeader(const WebString& key, const WebString& value);
@@ -81,7 +81,7 @@ class BLINK_PLATFORM_EXPORT WebServiceWorkerRequest {
WebURLRequest::FrameType frameType() const;
void setClientId(const WebString&);
- WebString clientId() const;
+ const WebString& clientId() const;
void setIsReload(bool);
bool isReload() const;

Powered by Google App Engine
This is Rietveld 408576698