Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp

Issue 2767343004: Return const references in the Blink SW API where possible (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h" 5 #include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h"
6 6
7 #include "platform/blob/BlobData.h" 7 #include "platform/blob/BlobData.h"
8 #include "platform/weborigin/KURL.h" 8 #include "platform/weborigin/KURL.h"
9 #include "public/platform/WebHTTPHeaderVisitor.h" 9 #include "public/platform/WebHTTPHeaderVisitor.h"
10 #include "public/platform/WebString.h" 10 #include "public/platform/WebString.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 } 48 }
49 49
50 void WebServiceWorkerRequest::assign(const WebServiceWorkerRequest& other) { 50 void WebServiceWorkerRequest::assign(const WebServiceWorkerRequest& other) {
51 m_private = other.m_private; 51 m_private = other.m_private;
52 } 52 }
53 53
54 void WebServiceWorkerRequest::setURL(const WebURL& url) { 54 void WebServiceWorkerRequest::setURL(const WebURL& url) {
55 m_private->m_url = url; 55 m_private->m_url = url;
56 } 56 }
57 57
58 WebURL WebServiceWorkerRequest::url() const { 58 const WebURL& WebServiceWorkerRequest::url() const {
59 return m_private->m_url; 59 return m_private->m_url;
60 } 60 }
61 61
62 void WebServiceWorkerRequest::setMethod(const WebString& method) { 62 void WebServiceWorkerRequest::setMethod(const WebString& method) {
63 m_private->m_method = method; 63 m_private->m_method = method;
64 } 64 }
65 65
66 WebString WebServiceWorkerRequest::method() const { 66 const WebString& WebServiceWorkerRequest::method() const {
67 return m_private->m_method; 67 return m_private->m_method;
68 } 68 }
69 69
70 void WebServiceWorkerRequest::setHeader(const WebString& key, 70 void WebServiceWorkerRequest::setHeader(const WebString& key,
71 const WebString& value) { 71 const WebString& value) {
72 if (equalIgnoringCase(key, "referer")) 72 if (equalIgnoringCase(key, "referer"))
73 return; 73 return;
74 m_private->m_headers.set(key, value); 74 m_private->m_headers.set(key, value);
75 } 75 }
76 76
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 } 176 }
177 177
178 WebURLRequest::FrameType WebServiceWorkerRequest::frameType() const { 178 WebURLRequest::FrameType WebServiceWorkerRequest::frameType() const {
179 return m_private->m_frameType; 179 return m_private->m_frameType;
180 } 180 }
181 181
182 void WebServiceWorkerRequest::setClientId(const WebString& clientId) { 182 void WebServiceWorkerRequest::setClientId(const WebString& clientId) {
183 m_private->m_clientId = clientId; 183 m_private->m_clientId = clientId;
184 } 184 }
185 185
186 WebString WebServiceWorkerRequest::clientId() const { 186 const WebString& WebServiceWorkerRequest::clientId() const {
187 return m_private->m_clientId; 187 return m_private->m_clientId;
188 } 188 }
189 189
190 void WebServiceWorkerRequest::setIsReload(bool isReload) { 190 void WebServiceWorkerRequest::setIsReload(bool isReload) {
191 m_private->m_isReload = isReload; 191 m_private->m_isReload = isReload;
192 } 192 }
193 193
194 bool WebServiceWorkerRequest::isReload() const { 194 bool WebServiceWorkerRequest::isReload() const {
195 return m_private->m_isReload; 195 return m_private->m_isReload;
196 } 196 }
197 197
198 } // namespace blink 198 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698