Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

Issue 2767343004: Return const references in the Blink SW API where possible (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h
diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h
index 2acdcfbfc7b097b10e82788f121ce1db6fb8abad..2b1a76f850aa9bf392aaad4d0a91529f573ea2d9 100644
--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h
+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h
@@ -51,7 +51,7 @@ class BLINK_PLATFORM_EXPORT WebServiceWorkerResponse {
unsigned short status() const;
void setStatusText(const WebString&);
- WebString statusText() const;
+ const WebString& statusText() const;
void setResponseType(WebServiceWorkerResponseType);
WebServiceWorkerResponseType responseType() const;
@@ -71,7 +71,7 @@ class BLINK_PLATFORM_EXPORT WebServiceWorkerResponse {
uint64_t blobSize() const;
void setStreamURL(const WebURL&);
- WebURL streamURL() const;
+ const WebURL& streamURL() const;
// Provides a more detailed error when status() is zero.
void setError(WebServiceWorkerResponseError);
@@ -81,10 +81,10 @@ class BLINK_PLATFORM_EXPORT WebServiceWorkerResponse {
int64_t responseTime() const;
void setCacheStorageCacheName(const WebString&);
- WebString cacheStorageCacheName() const;
+ const WebString& cacheStorageCacheName() const;
void setCorsExposedHeaderNames(const WebVector<WebString>&);
- WebVector<WebString> corsExposedHeaderNames() const;
+ const WebVector<WebString>& corsExposedHeaderNames() const;
#if INSIDE_BLINK
const HTTPHeaderMap& headers() const;
« no previous file with comments | « third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698