[MD Extensions] Respond with a load error when loading unpacked fails

[MD Extensions] Respond with a load error when loading unpacked fails

When loading an unpacked extension fails, respond with a load error that
indicates the error and includes the manifest file source to display to
the user. Typically, we'd surface an error through runtime.lastError,
but that doesn't allow for a rich response that includes multiple
fields.

To preserve backwards compatibility, only respond with the error when a
populateError flag is passed.

Add tests for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2767173002
Cr-Commit-Position: refs/heads/master@{#458971}
Committed: https://chromium.googlesource.com/chromium/src/+/c0877b06e466515ade9f012d4cce403983421dad

[Devlin, 2017-03-22 19:01:50]

Description was changed from

==========
[MD Extensions] Respond with a load error when loading unpacked fails

When loading an unpacked extension fails, respond with a load error that
indicates the error and includes the manifest file source to display to
the user. Typically, we'd surface an error through runtime.lastError,
but that doesn't allow for a rich response that includes multiple
fields.

To preserve backwards compatibility, only respond with the error when a
populateError flag is passed.

Add tests for the same.

BUG=529395
==========

to

==========
[MD Extensions] Respond with a load error when loading unpacked fails

When loading an unpacked extension fails, respond with a load error that
indicates the error and includes the manifest file source to display to
the user. Typically, we'd surface an error through runtime.lastError,
but that doesn't allow for a rich response that includes multiple
fields.

To preserve backwards compatibility, only respond with the error when a
populateError flag is passed.

Add tests for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2017-03-22 19:03:31]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2017-03-22 19:03:32]

Mind taking a look?

Michael, FYI.

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/extension_loader_handler.cc (right):

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/extension_loader_handler.cc:109: size_t line
= 0u;
Note: copy-paste.

[lazyboy, 2017-03-22 21:38:46]

lgtm with nits.

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/developer_private_api.h
(right):

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.h:406: //
Whether we populate a load error on failure.
nit: populate developer_private::LoadError on failure, opposed to lastError.

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/extension_loader_handler.cc (right):

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/extension_loader_handler.cc:109: size_t line
= 0u;
On 2017/03/22 19:03:32, Devlin wrote:
> Note: copy-paste.

Acknowledged.

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/extension_loader_handler.h (right):

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/extension_loader_handler.h:56: //
TODO(devlin): Move this out of here into developerPrivate.
optional nit: "Move this to developerPrivate."

[Devlin, 2017-03-22 23:42:08]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 23:43:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:00:40]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Devlin, 2017-03-23 00:14:23]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:30:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:30:17]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-03-23 01:30:59]

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/developer_private_api.h
(right):

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.h:406: //
Whether we populate a load error on failure.
On 2017/03/22 21:38:46, lazyboy wrote:
> nit: populate developer_private::LoadError on failure, opposed to lastError.

Done.

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/extension_loader_handler.h (right):

https://codereview.chromium.org/2767173002/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/extension_loader_handler.h:56: //
TODO(devlin): Move this out of here into developerPrivate.
On 2017/03/22 21:38:46, lazyboy wrote:
> optional nit: "Move this to developerPrivate."

Done.

[Devlin, 2017-03-23 01:31:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-03-23 01:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2767173002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-03-23 01:31:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:37:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490232676318550,
"parent_rev": "893656ac30d6e0d8afef9d0ce458276effb36dff", "commit_rev":
"c0877b06e466515ade9f012d4cce403983421dad"}

[commit-bot: I haz the power, 2017-03-23 01:38:03]

Description was changed from

==========
[MD Extensions] Respond with a load error when loading unpacked fails

When loading an unpacked extension fails, respond with a load error that
indicates the error and includes the manifest file source to display to
the user. Typically, we'd surface an error through runtime.lastError,
but that doesn't allow for a rich response that includes multiple
fields.

To preserve backwards compatibility, only respond with the error when a
populateError flag is passed.

Add tests for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions] Respond with a load error when loading unpacked fails

When loading an unpacked extension fails, respond with a load error that
indicates the error and includes the manifest file source to display to
the user. Typically, we'd surface an error through runtime.lastError,
but that doesn't allow for a rich response that includes multiple
fields.

To preserve backwards compatibility, only respond with the error when a
populateError flag is passed.

Add tests for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2767173002
Cr-Commit-Position: refs/heads/master@{#458971}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0877b06e466515ade9f012d4cce...
==========

[commit-bot: I haz the power, 2017-03-23 01:38:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c0877b06e466515ade9f012d4cce...