Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2768213002: [Closure Externs] Add wrapping parens on optional params (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Closure Externs] Add wrapping parens on optional params crrev.com/f9c093e54e11cb41c6f3402997a97be16568865f fixed optional params in callbacks, but forgot to wrap the type in params. function(!Foo|undefined) -> function((!Foo|undefined)) BUG=704242 Review-Url: https://codereview.chromium.org/2768213002 Cr-Commit-Position: refs/heads/master@{#458958} Committed: https://chromium.googlesource.com/chromium/src/+/38727920b34836a7a31c36c831c59fdcb1ed4dda

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/json_schema_compiler/js_externs_generator_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/js_util.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Devlin
Whoops - missed a part (closure typing leaves a little to be desired)
3 years, 9 months ago (2017-03-23 00:14:13 UTC) #4
lazyboy
lgtm
3 years, 9 months ago (2017-03-23 00:16:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768213002/20001
3 years, 9 months ago (2017-03-23 00:25:43 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 00:43:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38727920b34836a7a31c36c831c5...

Powered by Google App Engine
This is Rietveld 408576698