Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 2767173002: [MD Extensions] Respond with a load error when loading unpacked fails (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 // EntryPickerClient: 388 // EntryPickerClient:
389 void FileSelected(const base::FilePath& path) override; 389 void FileSelected(const base::FilePath& path) override;
390 void FileSelectionCanceled() override; 390 void FileSelectionCanceled() override;
391 391
392 // Callback for the UnpackedLoader. 392 // Callback for the UnpackedLoader.
393 void OnLoadComplete(const Extension* extension, 393 void OnLoadComplete(const Extension* extension,
394 const base::FilePath& file_path, 394 const base::FilePath& file_path,
395 const std::string& error); 395 const std::string& error);
396 396
397 private: 397 private:
398 void OnGotManifestError(const base::FilePath& file_path,
399 const std::string& error,
400 size_t line_number,
401 const std::string& manifest);
402
398 // Whether or not we should fail quietly in the event of a load error. 403 // Whether or not we should fail quietly in the event of a load error.
399 bool fail_quietly_; 404 bool fail_quietly_ = false;
405
406 // Whether we populate a developer_private::LoadError on load failure, as
407 // opposed to simply passing the message in lastError.
408 bool populate_error_ = false;
400 }; 409 };
401 410
402 class DeveloperPrivateChoosePathFunction 411 class DeveloperPrivateChoosePathFunction
403 : public DeveloperPrivateChooseEntryFunction { 412 : public DeveloperPrivateChooseEntryFunction {
404 public: 413 public:
405 DECLARE_EXTENSION_FUNCTION("developerPrivate.choosePath", 414 DECLARE_EXTENSION_FUNCTION("developerPrivate.choosePath",
406 DEVELOPERPRIVATE_CHOOSEPATH); 415 DEVELOPERPRIVATE_CHOOSEPATH);
407 416
408 protected: 417 protected:
409 ~DeveloperPrivateChoosePathFunction() override; 418 ~DeveloperPrivateChoosePathFunction() override;
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 protected: 613 protected:
605 ~DeveloperPrivateUpdateExtensionCommandFunction() override; 614 ~DeveloperPrivateUpdateExtensionCommandFunction() override;
606 ResponseAction Run() override; 615 ResponseAction Run() override;
607 }; 616 };
608 617
609 } // namespace api 618 } // namespace api
610 619
611 } // namespace extensions 620 } // namespace extensions
612 621
613 #endif // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API _H_ 622 #endif // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API _H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698