[MD Extensions] Respond with a load error when loading unpacked fails

chrome/browser/extensions/api/developer_private/developer_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
 
 #include <set>
 
 #include "base/files/file.h"
@@ skipping 377 matching lines @@
   // EntryPickerClient:
   void FileSelected(const base::FilePath& path) override;
   void FileSelectionCanceled() override;
 
   // Callback for the UnpackedLoader.
   void OnLoadComplete(const Extension* extension,
                       const base::FilePath& file_path,
                       const std::string& error);
 
  private:
+  void OnGotManifestError(const base::FilePath& file_path,
+                          const std::string& error,
+                          size_t line_number,
+                          const std::string& manifest);
+
   // Whether or not we should fail quietly in the event of a load error.
-  bool fail_quietly_;
+  bool fail_quietly_ = false;
+
+  // Whether we populate a load error on failure.

[lazyboy, 2017/03/22 21:38:46]

nit: populate developer_private::LoadError on failure, opposed to lastError.

[Devlin, 2017/03/23 01:30:59]

Done.

+  bool populate_error_ = false;
 };
 
 class DeveloperPrivateChoosePathFunction
     : public DeveloperPrivateChooseEntryFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("developerPrivate.choosePath",
                              DEVELOPERPRIVATE_CHOOSEPATH);
 
  protected:
   ~DeveloperPrivateChoosePathFunction() override;
@@ skipping 194 matching lines @@
  protected:
   ~DeveloperPrivateUpdateExtensionCommandFunction() override;
   ResponseAction Run() override;
 };
 
 }  // namespace api
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_