Move HalfFloatMaker to media

Move HalfFloatMaker to media

This commit moves HalfFloatMaker and its implementation from cc/resources
to media/video.


BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2763503002
Cr-Commit-Position: refs/heads/master@{#459716}
Committed: https://chromium.googlesource.com/chromium/src/+/76a24849ff7e58c331cfdf9fcac20db78d661669

[Uzair, 2017-03-20 05:49:32]

Description was changed from

==========
Move HalfFloatMaker to media

This includes the changes related to TODO  where it was
mentioned to move HalfFloatMaker from video resource updater
to media/.

BUG=""
==========

to

==========
Move HalfFloatMaker to media

This includes the changes related to TODO  where it was
mentioned to move HalfFloatMaker from video resource updater
to media/.

BUG=""
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Uzair, 2017-03-20 05:51:50]

Description was changed from

==========
Move HalfFloatMaker to media

This includes the changes related to TODO  where it was
mentioned to move HalfFloatMaker from video resource updater
to media/.

BUG=""
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move HalfFloatMaker to media

This includes the changes related to TODO  where it was
mentioned to move HalfFloatMaker from video resource updater
to media/.

BUG=""
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Uzair, 2017-03-20 05:51:50]

uzair.jaleel@samsung.com changed reviewers:
+ a.suchit@chromium.org, c.padhi@samsung.com, hubbe@chromium.org

[Uzair, 2017-03-20 05:53:37]

On 2017/03/20 05:51:50, Uzair wrote:
> mailto:uzair.jaleel@samsung.com changed reviewers:
> + mailto:a.suchit@chromium.org, mailto:c.padhi@samsung.com,
mailto:hubbe@chromium.org

Dear Reviewers,

PTAL

Thanks

[Uzair, 2017-03-21 04:47:20]

On 2017/03/20 05:53:37, Uzair wrote:
> On 2017/03/20 05:51:50, Uzair wrote:
> > mailto:uzair.jaleel@samsung.com changed reviewers:
> > + mailto:a.suchit@chromium.org, mailto:c.padhi@samsung.com,
> mailto:hubbe@chromium.org
> 
> Dear Reviewers,
> 
> PTAL
> 
> Thanks

Dear Reviewers,

PTAL

Thanks

[a.suchit2, 2017-03-21 10:24:22]

Peer review LGTM

[a.suchit2, 2017-03-21 10:36:14]

No need to mentioned that it is todo in description.
It would be checked by reviewers itself while review.

So below is enough in description:
moved HalfFloatMaker class from cc/resources videoResourceUpdater
to media/video.

[a.suchit2, 2017-03-21 10:36:16]

No need to mentioned that it is todo in description.
It would be checked by reviewers itself while review.

So below is enough in description:
moved HalfFloatMaker class from cc/resources videoResourceUpdater
to media/video.

[hubbe, 2017-03-21 17:22:51]

On 2017/03/21 10:36:16, a.suchit2 wrote:
> No need to mentioned that it is todo in description.
> It would be checked by reviewers itself while review.
> 
> So below is enough in description:
> moved HalfFloatMaker class from cc/resources videoResourceUpdater
> to media/video.

You also need to move the classes that extend HalfFloatMaker to media.

[Uzair, 2017-03-22 12:32:42]

Description was changed from

==========
Move HalfFloatMaker to media

This includes the changes related to TODO  where it was
mentioned to move HalfFloatMaker from video resource updater
to media/.

BUG=""
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move HalfFloatMaker to media

This commit moves HalfFloatMaker and its implementation from cc/resources
to media/video.


BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Uzair, 2017-03-22 12:39:47]

On 2017/03/21 17:22:51, hubbe wrote:
> On 2017/03/21 10:36:16, a.suchit2 wrote:
> > No need to mentioned that it is todo in description.
> > It would be checked by reviewers itself while review.
> > 
> > So below is enough in description:
> > moved HalfFloatMaker class from cc/resources videoResourceUpdater
> > to media/video.
> 
> You also need to move the classes that extend HalfFloatMaker to media.

Done.

PTAL

[harryclone93, 2017-03-22 12:48:33]

The HalfFloatMaker is really help me to move medias.I use this HalfFloatMaker to
my website - http://tampa-397.comfortkeepers.com/  .I think so many people
searching for this topic.Thank you for your information.

[hubbe, 2017-03-22 17:48:22]

https://codereview.chromium.org/2763503002/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2763503002/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:301:
std::unique_ptr<media::HalfFloatMaker> VideoResourceUpdater::NewHalfFloatMaker(
Move this function to media

https://codereview.chromium.org/2763503002/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:464: // TODO(hubbe): Move all conversion
(and upload?) code to media/.
Update this TODO

https://codereview.chromium.org/2763503002/diff/80001/media/video/half_float_...
File media/video/half_float_maker_xor.h (right):

https://codereview.chromium.org/2763503002/diff/80001/media/video/half_float_...
media/video/half_float_maker_xor.h:25: class MEDIA_EXPORT HalfFloatMaker_xor :
public media::HalfFloatMaker {
I don't think you need to expose this class in a header file.
Just put it in half_float_maker.c and have a factory function for
constructing an HalfFloatMaker which decides between the xor and libyuv version.

[Uzair, 2017-03-23 07:13:30]

Done.

PTAL

https://codereview.chromium.org/2763503002/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2763503002/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:301:
std::unique_ptr<media::HalfFloatMaker> VideoResourceUpdater::NewHalfFloatMaker(
On 2017/03/22 17:48:22, hubbe wrote:
> Move this function to media

Done.

https://codereview.chromium.org/2763503002/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:464: // TODO(hubbe): Move all conversion
(and upload?) code to media/.
On 2017/03/22 17:48:22, hubbe wrote:
> Update this TODO

Done.

https://codereview.chromium.org/2763503002/diff/80001/media/video/half_float_...
File media/video/half_float_maker_xor.h (right):

https://codereview.chromium.org/2763503002/diff/80001/media/video/half_float_...
media/video/half_float_maker_xor.h:25: class MEDIA_EXPORT HalfFloatMaker_xor :
public media::HalfFloatMaker {
On 2017/03/22 17:48:22, hubbe wrote:
> I don't think you need to expose this class in a header file.
> Just put it in half_float_maker.c and have a factory function for
> constructing an HalfFloatMaker which decides between the xor and libyuv
version.

Done.

[Uzair, 2017-03-23 07:15:01]

Description was changed from

==========
Move HalfFloatMaker to media

This commit moves HalfFloatMaker and its implementation from cc/resources
to media/video.


BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move HalfFloatMaker to media

This commit moves HalfFloatMaker and its implementation from cc/resources
to media/video.


BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[hubbe, 2017-03-23 17:46:12]

Almost there...

https://codereview.chromium.org/2763503002/diff/140001/cc/resources/video_res...
File cc/resources/video_resource_updater_unittest.cc (right):

https://codereview.chromium.org/2763503002/diff/140001/cc/resources/video_res...
cc/resources/video_resource_updater_unittest.cc:543:
TEST_F(VideoResourceUpdaterTest, MakeHalfFloatTest) {
Move this test to media::

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
File media/video/half_float_maker.cc (right):

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
media/video/half_float_maker.cc:22: 
extra newline

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
media/video/half_float_maker.cc:47: class HalfFloatMaker_libyuv : public
HalfFloatMaker {
Add class comment.

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
File media/video/half_float_maker.h (right):

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
media/video/half_float_maker.h:32: static std::unique_ptr<HalfFloatMaker>
NewHalfFloatMaker(
Please add a comment.
Might also want to add a comment before the class pointing out this function as
the way to create a HalfFloatMaker

[Uzair, 2017-03-24 05:39:08]

Done.
PTAL

https://codereview.chromium.org/2763503002/diff/140001/cc/resources/video_res...
File cc/resources/video_resource_updater_unittest.cc (right):

https://codereview.chromium.org/2763503002/diff/140001/cc/resources/video_res...
cc/resources/video_resource_updater_unittest.cc:543:
TEST_F(VideoResourceUpdaterTest, MakeHalfFloatTest) {
On 2017/03/23 17:46:11, hubbe wrote:
> Move this test to media::

Done.

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
File media/video/half_float_maker.cc (right):

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
media/video/half_float_maker.cc:22: 
On 2017/03/23 17:46:11, hubbe wrote:
> extra newline
removed extra line.

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
media/video/half_float_maker.cc:47: class HalfFloatMaker_libyuv : public
HalfFloatMaker {
On 2017/03/23 17:46:11, hubbe wrote:
> Add class comment.

Done.

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
File media/video/half_float_maker.h (right):

https://codereview.chromium.org/2763503002/diff/140001/media/video/half_float...
media/video/half_float_maker.h:32: static std::unique_ptr<HalfFloatMaker>
NewHalfFloatMaker(
On 2017/03/23 17:46:11, hubbe wrote:
> Please add a comment.
> Might also want to add a comment before the class pointing out this function
as
> the way to create a HalfFloatMaker

Done.

[Uzair, 2017-03-24 05:43:29]

uzair.jaleel@samsung.com changed reviewers:
+ danakj@chromium.org

[hubbe, 2017-03-24 17:26:16]

lgtm

https://codereview.chromium.org/2763503002/diff/160001/media/video/half_float...
File media/video/half_float_maker.cc (right):

https://codereview.chromium.org/2763503002/diff/160001/media/video/half_float...
media/video/half_float_maker.cc:46: // Convert plane of 16 bit shorts to half
floats.
add "using libyuv" to end of sentence at least.

[danakj, 2017-03-24 17:29:48]

cc LGTM

[Uzair, 2017-03-27 04:28:49]

Done

https://codereview.chromium.org/2763503002/diff/160001/media/video/half_float...
File media/video/half_float_maker.cc (right):

https://codereview.chromium.org/2763503002/diff/160001/media/video/half_float...
media/video/half_float_maker.cc:46: // Convert plane of 16 bit shorts to half
floats.
On 2017/03/24 17:26:16, hubbe wrote:
> add "using libyuv" to end of sentence at least.
> 

Done.

[Uzair, 2017-03-27 04:29:42]

The CQ bit was checked by uzair.jaleel@samsung.com

[Uzair, 2017-03-27 04:29:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
a.suchit@chromium.org, danakj@chromium.org, hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2763503002/#ps180001
(title: "Edited comment for class HalfFloatMaker_libyuv")

[commit-bot: I haz the power, 2017-03-27 04:29:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 04:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 04:40:11]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Uzair, 2017-03-27 05:03:44]

The CQ bit was checked by uzair.jaleel@samsung.com

[Uzair, 2017-03-27 05:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
a.suchit@chromium.org, danakj@chromium.org, hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2763503002/#ps200001
(title: "Added math.h in half_float_maker_unittest.cc for POW undefined error")

[commit-bot: I haz the power, 2017-03-27 05:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 06:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:46:11]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Uzair, 2017-03-27 07:08:09]

The CQ bit was checked by uzair.jaleel@samsung.com

[commit-bot: I haz the power, 2017-03-27 07:08:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 07:54:37]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1490598489706360,
"parent_rev": "c3434c4e95fac9bad103211dde483a42f555255a", "commit_rev":
"76a24849ff7e58c331cfdf9fcac20db78d661669"}

[commit-bot: I haz the power, 2017-03-27 07:55:45]

Description was changed from

==========
Move HalfFloatMaker to media

This commit moves HalfFloatMaker and its implementation from cc/resources
to media/video.


BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move HalfFloatMaker to media

This commit moves HalfFloatMaker and its implementation from cc/resources
to media/video.


BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2763503002
Cr-Commit-Position: refs/heads/master@{#459716}
Committed:
https://chromium.googlesource.com/chromium/src/+/76a24849ff7e58c331cfdf9fcac2...
==========

[commit-bot: I haz the power, 2017-03-27 07:55:46]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/76a24849ff7e58c331cfdf9fcac2...